Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(github): reopen autoclosed PRs #9305

Merged
merged 10 commits into from Mar 30, 2021
Merged

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Mar 28, 2021

Changes:

Reuses/reopens autoclosed PRs if possible (Second attempt)

Context:

Closes #3982

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins marked this pull request as ready for review March 28, 2021 20:06
@rarkins rarkins requested a review from viceice March 28, 2021 20:06
Copy link
Collaborator

@zharinov zharinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rarkins rarkins enabled auto-merge (squash) March 30, 2021 12:04
@rarkins rarkins merged commit 94535d5 into master Mar 30, 2021
@rarkins rarkins deleted the feat/3982-github-reopen-autoclosed branch March 30, 2021 12:07
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.98.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@erezrokah
Copy link

erezrokah commented Apr 1, 2021

We're seeing renovate PRs being re-opened with conflicting files:
netlify/cli#1994
netlify/cli#1801
image

Also, we have a schedule set so I believe those PRs should be re-opened based on the schedule?

FYI, I believe those PRs were auto closed since we have lockFileMaintenance enabled and we merge the lock file PR (which auto closes all other individual PRs)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for existing autoclosed PR before opening new PR
5 participants