Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert npmrc handling changes #9347

Merged
merged 11 commits into from Apr 1, 2021
Merged

fix: revert npmrc handling changes #9347

merged 11 commits into from Apr 1, 2021

Conversation

rarkins
Copy link
Collaborator

@rarkins rarkins commented Apr 1, 2021

This reverts commit 5949f39.

Changes:

Reverts all npmrc changes since 24.95.1

Context:

Something is not quite right, causing excessive artifact errors in the app.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@rarkins rarkins marked this pull request as ready for review April 1, 2021 11:41
@rarkins rarkins requested a review from viceice April 1, 2021 11:41
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully it fixes the issues 🤞

@rarkins rarkins merged commit 2fb87ed into master Apr 1, 2021
@rarkins rarkins deleted the fix/revert-npmrc branch April 1, 2021 12:19
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 24.98.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants