Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GitLab] Remove 25000 character limit on descriptions #9436

Closed
fgblomqvist opened this issue Apr 7, 2021 · 3 comments · Fixed by #9452
Closed

[GitLab] Remove 25000 character limit on descriptions #9436

fgblomqvist opened this issue Apr 7, 2021 · 3 comments · Fixed by #9452
Assignees
@fgblomqvist
Labels
platform:gitlab GitLab Platform priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:feature Feature (new functionality)

Comments

@fgblomqvist
Copy link
Contributor

fgblomqvist commented Apr 7, 2021 •
edited

What would you like Renovate to be able to do?

It currently limits description lengths to 25k, per this discussion.
The fix in GitLab is here.
The fix was released in GitLab 13.4, and therefore the limit is no longer necessary (see release log here).

I will submit a PR for this 🙂
@fgblomqvist fgblomqvist added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality) labels Apr 7, 2021
@fgblomqvist
Copy link
Contributor Author

I have this change ready, including updated tests.
It can be seen here: https://github.com/fgblomqvist/renovate/commit/18b3f0489b22d4e85c859056813dc3c0c29137e7

However, I based it off of my addReviewers branch (since I expect that one to get merged very soon) since I setup the API version stuff in there. Therefore, I'll wait with submitting the PR until that one gets merged.

@viceice
Copy link
Member

viceice commented Apr 8, 2021

@fgblomqvist addReviewers PR merged 😉

@viceice viceice added platform:gitlab GitLab Platform priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:ready and removed priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started labels Apr 8, 2021
@viceice viceice added status:in-progress Someone is working on implementation and removed status:ready labels Apr 8, 2021
@fgblomqvist fgblomqvist mentioned this issue Apr 8, 2021
Merged
6 tasks
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 24.107.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@fgblomqvist fgblomqvist

Labels
platform:gitlab GitLab Platform priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:in-progress Someone is working on implementation type:feature Feature (new functionality)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(gitlab): Allow descriptions longer than 25K characters
3 participants
@fgblomqvist @viceice @renovate-release