feat(release-notes): running unemojify on release notes #9535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lucavb
force-pushed
the
feature/emoji-release-notes
branch
from
3033d91
to
cd9ae8b
Compare
lucavb
changed the title
viceice
approved these changes
Apr 14, 2021
|
This affects all platforms though - are we sure about that? @JamieMagee |
It has only an effect if |
|
🎉 This PR is included in version 24.115.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This invokes the new
unemojifyfunction on the fetched release notes. This PR is basically the result of #9219Context:
Bitbucket (depending on the database in the background) is really allergic to emojis and crashes silently when using them. While this can already be configured for renovate itself, the contents of the changelog of a project might still contain some.
Closes #9219
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via:
I have added a unit test for
emoji.ts. If there is some place where you recommend testing the actual change that I have made, then I'll gladly add this. This is after all my first PR to renovate.