New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update actions/setup-java to v2.0.0 #9601
chore(deps): update actions/setup-java to v2.0.0 #9601
Conversation
I don't know if we care about always testing on the latest version of Java? There's a Boolean property Right now the "implicit" default is that Documentation for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should test latest major lts java version
This is what GitHub Actions comes with right now:
So if we want to benefit from the GitHub Action pre-installed version of Java, maybe we should set Or we could tell the action to fetch the latest Java LTS release by setting |
lets use adopt and java 11 for now |
🎉 This PR is included in version 24.119.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
actions/setup-java
tov2.0.0
from1.4.3
adopt
distribution of Java (mandatory to specify this)jre
Java package (optional to specify this)Context:
Renovate Bot listed this update on the Dependency Dashboard, but we need to take manual action anyways due to some breaking changes.
The major breaking change is that we now must specify what distribution of Java we want to use.
Version 1 of the action uses the Zulu distribution, so I'm sticking with that.We decided to go with the
adopt
distribution instead.It's optional to specify what version of the Java package we use (
jdk
/jre
),v1 uses.jdk
, so I'm sticking with that as wellWe decided to use the
jre
version.Please read the guide here and check my work: https://github.com/actions/setup-java/blob/main/docs/switching-to-v2.md
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: