refactor(http): Import proper OutgoingHttpHeaders on all http clients #9653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
reviewed
Apr 20, 2021
lib/util/http/types.ts
Outdated
| @@ -23,3 +23,7 @@ export interface RequestStats { | |||
| duration: number; | |||
| queueDuration: number; | |||
| } | |||
|
|
|||
| export interface OutgoingHttpHeaders { | |||
There was a problem hiding this comment.
We should extend from Record here
|
Deep merge of |
viceice
reviewed
Apr 20, 2021
lib/util/http/types.ts
Outdated
| @@ -23,3 +23,7 @@ export interface RequestStats { | |||
| duration: number; | |||
| queueDuration: number; | |||
| } | |||
|
|
|||
| export interface OutgoingHttpHeaders extends Record<string, unknown> { | |||
| [header: string]: string | string[] | undefined; | |||
There was a problem hiding this comment.
Remove and add this types to second record type
There was a problem hiding this comment.
Replaced by Record<string, string | string[] | undefined>, because empty interfaces don't lint well
zharinov
commented
Apr 20, 2021
| @@ -23,3 +23,5 @@ export interface RequestStats { | |||
| duration: number; | |||
| queueDuration: number; | |||
| } | |||
|
|
|||
| export type OutgoingHttpHeaders = Record<string, string | string[] | undefined>; | |||
There was a problem hiding this comment.
@viceice Okay, just commit your suggestion, please 🙃
viceice
approved these changes
Apr 20, 2021
|
🎉 This PR is included in version 24.119.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Fix imports, remove
unknowntype, remove TODO item.Context:
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: