Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Bazel to use autoReplace + artifacts #9667

Closed
rarkins opened this issue Apr 21, 2021 · 6 comments · Fixed by #20318
Closed

Refactor Bazel to use autoReplace + artifacts #9667

rarkins opened this issue Apr 21, 2021 · 6 comments · Fixed by #20318
Assignees
Labels
manager:bazel Bazel WORKSPACE files priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code

Comments

@rarkins
Copy link
Collaborator

rarkins commented Apr 21, 2021

I think we should refactor our Bazel handling to use getArtifacts instead of trying to update them all in one go using updateDependency().

Whenever URLs, digests or checksums are dependent on the version - and not independently updatable - it should usually mean we use artifacts.

@rarkins rarkins added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code status:requirements Full requirements are not yet known, so implementation should not be started labels Apr 21, 2021
@zharinov zharinov self-assigned this Apr 21, 2021
@HonkingGoose

This comment has been minimized.

@rverma-dev
Copy link

@zharinov Also it seems that the current implementation for bezel rules doesn't handle tags. e.g. If I define the URL as "https://github.com/bazelbuild/rules_proto/archive/refs/tags/4.0.0-3.20.0.tar.gz", this is not detected at all

@viceice
Copy link
Member

viceice commented Aug 2, 2022

@zharinov Also it seems that the current implementation for bezel rules doesn't handle tags. e.g. If I define the URL as "https://github.com/bazelbuild/rules_proto/archive/refs/tags/4.0.0-3.20.0.tar.gz", this is not detected at all

that's not a tag, it's a archive of a tag. this is something totally different at renovate.

@cpsauer
Copy link
Contributor

cpsauer commented Aug 30, 2022

@viceice and @rverma-nsl: I think the above tag discussion might be arising because GitHub has changed the default URL for releases and tags on the release page. I've written up #17498 with more details, to keep that issue separate.

@rarkins
Copy link
Collaborator Author

rarkins commented Dec 15, 2022

Example from one of our fixtures: https://github.com/renovatebot/renovate/blob/e344b538f1b85c6a4fb0fb4f852a6fabb07392e1/lib/modules/manager/bazel/__fixtures__/WORKSPACE1#LL62

The url is https://github.com/bazelbuild/rules_nodejs/releases/download/5.5.3/rules_nodejs-core-5.5.3.tar.gz

Instead of detecting and updating 5.5.3 twice, we should only extract and update the first instance of it. The filename rules_nodejs-core-5.5.3.tar.gz would be the part updated as "artifacts".

@rarkins rarkins changed the title Refactor Bazel to use updateArtifacts Refactor Bazel to use autoReplace + artifacts Dec 17, 2022
@renovate-release
Copy link
Collaborator

🎉 This issue has been resolved in version 34.132.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:bazel Bazel WORKSPACE files priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants