New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: master branch -> main branch, default branch -> base branch #9808
docs: master branch -> main branch, default branch -> base branch #9808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some questions from my end. 😉
I think all platforms support arbitrary domain names. It was always possible to change the default branch of a repo. Let's assume as much. |
Yeah, let's speak about default branch where possible and use main and / or master as some examples |
Okay!
All of our code examples now use |
🤔 i think using default branch is more future prove. @rarkins what do you think? |
You're probably right. Although now I look, I think many of these should be "the base branch" instead. |
Yeah, base branch is probably a better terminology for renovate |
If we want to be consistent throughout, I would need to find/replace |
Sounds good |
I think this is ready for another round of review. 😄 I've changed the pull request title as the scope of the PR has changed between opening and now, please check if that's good. Feel free to change it into something else if needed. 😉 |
Co-authored-by: Rhys Arkins <rhys@arkins.net>
@rarkins said earlier:
I made the change to Can you explain why you didn't like |
Base branch is a relative term, different to default branch. A repo has only one default branch (eg main/master) but base branch is relative to PRs and there can be multiple. To a PR, it's the base branch that matters. To a repo, it's default branch. |
Ah okay! 😄 |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Rhys Arkins <rhys@arkins.net>
🎉 This PR is included in version 25.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
master
withmain
where possible and supportedmaster
vsmain
branch thing in the FAQContext:
Closes #9693.
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: