-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(kustomize): Allow port numbers in git URLs #9921
fix(kustomize): Allow port numbers in git URLs #9921
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this regex is wrong, it wrongly allows http://abc.domain.com/1234/project/path
so the number isn't treated as project path.
You're right. I'll abort the PR since I don't have an idea on how to improve the regex. |
Please reopen, I'll fix the regex, it's not too hard for me. 😉 |
Cool, any help is appreciated. :) |
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@flo-02-mu Please request another review via GitHub ui when you are ready for another review. We don't watch git push notifications. 😉 |
🎉 This PR is included in version 25.18.6 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Changes:
Adjust the regex in a way that the port number in a URL is not treated as a username.
Context:
Closes #9918
Documentation (please check one with an [x])
How I've tested my work (please tick one)
I have verified these changes via: