Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kustomize): Allow port numbers in git URLs #9921

Merged

Conversation

flo-02-mu
Copy link
Contributor

Changes:

Adjust the regex in a way that the port number in a URL is not treated as a username.

Context:

Closes #9918

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • No new tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@flo-02-mu flo-02-mu changed the title 9918 [kustomize] Allow port numbers in git URLs fix(kustomize) Allow port numbers in git URLs May 9, 2021
@flo-02-mu flo-02-mu changed the title fix(kustomize) Allow port numbers in git URLs fix(kustomize): Allow port numbers in git URLs May 9, 2021
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this regex is wrong, it wrongly allows http://abc.domain.com/1234/project/path so the number isn't treated as project path.

@flo-02-mu
Copy link
Contributor Author

I think this regex is wrong, it wrongly allows http://abc.domain.com/1234/project/path so the number isn't treated as project path.

You're right. I'll abort the PR since I don't have an idea on how to improve the regex.

@flo-02-mu flo-02-mu closed this May 10, 2021
@viceice
Copy link
Member

viceice commented May 11, 2021

Please reopen, I'll fix the regex, it's not too hard for me. 😉

@flo-02-mu flo-02-mu reopened this May 11, 2021
@flo-02-mu
Copy link
Contributor Author

Please reopen, I'll fix the regex, it's not too hard for me. 😉

Cool, any help is appreciated. :)

@viceice
Copy link
Member

viceice commented May 11, 2021

@flo-02-mu Please request another review via GitHub ui when you are ready for another review. We don't watch git push notifications. 😉

@viceice viceice enabled auto-merge (squash) May 11, 2021 20:15
@viceice viceice merged commit dd712a7 into renovatebot:main May 11, 2021
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 25.18.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kustomize manager parses git endpoint with port number incorrectly
3 participants