Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow compilation of post-upgrade commands #7632

Merged
merged 5 commits into from Nov 10, 2020

Conversation

IKatsuba
Copy link
Contributor

@IKatsuba IKatsuba commented Nov 2, 2020

Changes:

This PR adds compilation as templates for post-upgrade commands.

Context:

I would like to configure Angular migrations for some npm packages. For this feature, I have to know about the previous and current package versions in post-upgrade commands. But it is possible only if commands will compile as templates in the changing context. For example

{
  "postUpgradeTasks": {
    "commands": [
      "npm ci --ignore-scripts",
      "npx ng update {{{depName}}} --from={{{fromVersion}}} --to={{{toVersion}}} --migrateOnly --allowDirty --force"
    ],
    "fileFilters": ["**/**"]
  }
}

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please tick one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added unit tests, or
  • Unit tests + ran on a real repository

@CLAassistant
Copy link

CLAassistant commented Nov 2, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should first open an issue to discuss this changes.

@viceice viceice linked an issue Nov 2, 2020 that may be closed by this pull request
@IKatsuba IKatsuba requested a review from viceice November 5, 2020 12:45
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
@IKatsuba IKatsuba requested a review from rarkins November 5, 2020 15:29
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small suggestions

docs/usage/self-hosted-configuration.md Outdated Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Show resolved Hide resolved
docs/usage/self-hosted-configuration.md Show resolved Hide resolved
@IKatsuba IKatsuba requested a review from viceice November 6, 2020 08:33
@IKatsuba
Copy link
Contributor Author

IKatsuba commented Nov 9, 2020

@viceice @rarkins guys, I really need this feature:) Check out the PR, please

@IKatsuba
Copy link
Contributor Author

When is the release planned?

@rarkins rarkins changed the title feat: added compilation of the template for post-upgrade commands feat: allow compilation of post-upgrade commands Nov 10, 2020
@rarkins rarkins merged commit b22ea76 into renovatebot:master Nov 10, 2020
@rarkins
Copy link
Collaborator

rarkins commented Nov 10, 2020

@IKatsuba we release per-commit

@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 23.76.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Post-upgrade commands compile as templates
5 participants