Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Prettier linter #2

Open
6 tasks
HonkingGoose opened this issue Jul 20, 2022 · 3 comments
Open
6 tasks

Run Prettier linter #2

HonkingGoose opened this issue Jul 20, 2022 · 3 comments

Comments

@HonkingGoose
Copy link
Contributor

Goal:

Speed up reviewing PRs by enforcing one code style for the project.

Todo:

  • Install Prettier linter as development dependency
  • Create basic Prettier config
  • Create two script entries in the package.json file:
    • prettier that runs Prettier with the --cache option
    • prettier-fix that runs prettier with the --cache option and fixes the files
  • Create basic GitHub Action run to check if the prettier command run passes
@PhilipAbed
Copy link
Contributor

PhilipAbed commented Jul 21, 2022

adding extra dependencies to this project might change the outcome results of the tutorial right?

@HonkingGoose
Copy link
Contributor Author

I'm probably getting something mixed up here. 🙈😄

The goal for this project is: 1

I would like for us to have a specific "demo" repository with a hands-on getting started guide where users can fork it and follow the guide to experience Renovate. E.g. starting simply with onboarding but then showing:

  • making config changes during onboarding and seeing the change
  • making changes after, e.g. adding package rules and common features like labels, assignees, etc.

This should be part of our "official" documentation and maintained to stay accurate.

When we say "maintained to stay accurate" do we mean:

  • update the project dependencies ourselves/with Renovate?
  • update the documentation whenever Renovate bot configuration or other upstream like Kubernetes/AWS/Docker changes?
  • both of the above?

Do we want this repository to have "stale dependencies"? So that the examples in the doc match the behavior after people fork the renovatebot/tutorial repository?

Right now, I don't understand why adding Prettier may cause problems. 😉

Footnotes

  1. https://github.com/renovatebot/renovate/issues/15384#issuecomment-1113906255

@PhilipAbed
Copy link
Contributor

PhilipAbed commented Jul 21, 2022

ill test it out, thing is, we have Screenshots of the dependencies,
im hoping renovate config:base ignores devDependencies if it changes the Order of the PRs, i will give it a test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants