Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RENPY_DEPS_INSTALL uses "::" to separate paths instead of os.pathsep #1499

Closed
Uzume opened this issue Jul 2, 2018 · 2 comments
Closed

RENPY_DEPS_INSTALL uses "::" to separate paths instead of os.pathsep #1499

Uzume opened this issue Jul 2, 2018 · 2 comments

Comments

@Uzume
Copy link

Uzume commented Jul 2, 2018

I considered directly making a pull request but I instead decided to first bring the issue up here for discussion in case there is some amazing good reason for this that I cannot understand.

It seems os.pathsep is designed exactly for this purpose so this seem like a bug to me.

For reference RENPY_DEPS_INSTALL seems to have been introduced in 2006 f9bb838 but :: path separation syntax was first introduced in 2009 a0fda2f

@renpytom
Copy link
Member

renpytom commented Jul 4, 2018

Not a good reason, other than perhaps os.pathsep not existing (or more likely, me not knowing about it) when that was written. I made the change, as I wanted to make sure we still support :: for compatibility with scripts that build Ren'Py.

@Uzume
Copy link
Author

Uzume commented Jul 5, 2018

I had a feeling there were probably some external build script dependencies and exactly why I brought it here instead of directly making a pull request.

Thanks for the quick turn around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants