Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trailing colon after show at statement is parsed without error, but changes behavior by resetting some properties on animation start #4792

Closed
hsandt opened this issue Jun 28, 2023 · 1 comment

Comments

@hsandt
Copy link
Contributor

hsandt commented Jun 28, 2023

MWE

Repro bug - Trailing colon after show at caused property reset.zip

Or just the code below in your script.rpy:

define e = Character('Eileen', color="#c8ffc8")
image eileen = Transform("images/eileen happy.png")

transform t:
    linear 1.0 xpos 0.5

label start:

    "BUG REPRO: trailing colon after show at statement does not cause parse error, but changes behavior: character warps to left before moving"

    show e:
        xpos 0.7

    "Ready to move?"

    # 1. Uncomment this for expected behavior
    # show e at t

    # 2. Uncomment this for odd behavior
    show e at t:

    "Moving!"

    return

Run with line 1. uncommented to see expected behavior.

Renpy 8 1 1 trailing colon show at reset property - expected

Run with line 2. uncommented to see odd behavior: character warps to left (apparently due to xpos reset) before moving to target position
Renpy 8 1 1 trailing colon show at reset property

Oddly enough, even when I used a colon with actual code below to change sprite xoffset, the xpos seemed to reset as well. So maybe the colon is actually setting up something in all cases, then since there is no code below to set positions, the default values show off?

@hsandt
Copy link
Contributor Author

hsandt commented Jun 29, 2023

Wow, thanks, you're really killing bugs as fast I report them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant