Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Select Input does not prevent user field input when search is set to false on Select #143

Open
jgrubard opened this issue Mar 10, 2021 · 0 comments
Labels
bug Fix reported issue.

Comments

@jgrubard
Copy link
Collaborator

jgrubard commented Mar 10, 2021

Prerequisites

  • Version: @rent_avail/select@0.3.10
  • Operating system: Mac OSX
  • Bits: 64 bits

Step to reproduce (actual behavior)

When search on the Select component is set to false, it appears that the user cannot type into the input field, but the value is still being captured.

Expected behavior

No value should be captured when search is set to false.

A potential solution is adding readOnly: !state.search to the inputProps in packages/select/src/select-input.js.

This was made workable by adding the readOnly prop to the select input, since it will pass that prop along to the Input component, along with search={false}.

Any message or error

N/A

Resources

N/A

@jgrubard jgrubard added the bug Fix reported issue. label Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix reported issue.
Projects
None yet
Development

No branches or pull requests

1 participant