Fix swift entity names #222
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… properties and user info keys
This was referenced Jul 14, 2014
Closed
|
It's a year later. These still relevant? |
|
Guess not. Closing it out. |
|
Yeah, sorry dude — no idea. I haven't done much Core Data in the last 12 months. I think it might be necessary, but |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is necessary to set the class name of an entity in your data model to the fully qualified Swift classname, plus its parent module, i.e. "MyThingKit.Account". This PR updates mogenerator to any modules from the front of the class name returned from
- [NSEntityDescription managedObjectClassName]so that it just becomes "Account" in generated Swift output.There might be a nicer way to come at this, and using
pathExtensionto achieve the module stripping isn't semantically great — but it works OK.I'm happy to update this PR based on any feedback.
This PR also includes the contents of #221. Feel free to merge it first, or this one in it's entirety — they both came from the same branch so it should be a clean merge.