Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToyCarSpecular.gltf is different from expected result #32

Closed
cx20 opened this issue Feb 20, 2021 · 16 comments
Closed

ToyCarSpecular.gltf is different from expected result #32

cx20 opened this issue Feb 20, 2021 · 16 comments

Comments

@cx20
Copy link

cx20 commented Feb 20, 2021

I tried ToyCarSpecular.gltf, a draft model of Khronos. (The model has been renamed in the gltf-test repository to distinguish it from ToyCar.gltf.)
This model demonstrates the usage of KHR_materials_specular, KHR_materials_ior, KHR_materials_transmission and KHR_materials_clearcoat.
Please note that this model is different from this sample.

I noticed about two problems when compared with Babylon.js.

  • When only IBL is on, the flame emblem and car number are specularly reflected.
  • The part of the cloth looks like a metallic luster
IBL Lights Babylon.js + ToyCarSpecular.gltf result: RedCube.js + ToyCarSpecular.gltf result:
off off image image
off on image image
on off image image
on on image image
@Reon90
Copy link
Owner

Reon90 commented Feb 22, 2021

@cx20 do you have source of model, because I'm not sure about fabric material (The part of the cloth looks like a metallic luster).
When only IBL is on, the flame emblem and car number are specularly reflected. - fixed in 2.5.12

@cx20
Copy link
Author

cx20 commented Feb 22, 2021

do you have source of model, because I'm not sure about fabric material

The glTF file is shown below, but you will have to ask the creator if there is an original source.
ToyCarSpecular.zip

The part of the cloth looks like a metallic luster

The areas that I see as metallic luster are as follows.
In Babylon.js, Fabric reflects the Base Color texture, but in Red Cube it appears to have a metallic luster.

Library ToyCarSpecular.gltf result
Babylon.js image
RedCube.js image

See below for the expected results of this model. Babylon.js seems to be the closest to the expected result so far.
KhronosGroup/glTF-Sample-Models#268 (comment)

@cx20
Copy link
Author

cx20 commented Feb 22, 2021

When only IBL is on, the flame emblem and car number are specularly reflected. - fixed in 2.5.12

I confirmed this. Thank you for your support.

@Reon90
Copy link
Owner

Reon90 commented Feb 22, 2021

@cx20 I’m trying to told you that Babylonjs is not source of true. To verify rendering we need some ground truth renderer, e.g. Blender etc.

@cx20
Copy link
Author

cx20 commented Feb 22, 2021

Below is the result of path-traced. Perhaps this is the expected result.
KhronosGroup/glTF-Sample-Models#268 (comment)
image

Current result:
image

@cx20
Copy link
Author

cx20 commented Feb 24, 2021

@emackey Any advice on how to test KHR_materials_specular?

@emackey
Copy link

emackey commented Feb 24, 2021

We're still working to get a better test model for specular. The toy car is the only one available at this point, but for me at least, it's not intuitive why the car comes out that color. It would be better for us to have a model that's more explicit, but we don't have one yet.

The closest thing to ground truth currently is a prototype path tracer from Dassault. But there was a change to the specular parameters just a couple weeks ago, and I don't know if this path tracer was updated to support that yet. This should all get straightened out before we send specular over for ratification.

Live: https://dassaultsystemes-technology.github.io/dspbr-pt/

Source: https://github.com/dassaultsystemes-technology/dspbr-pt/

@cx20
Copy link
Author

cx20 commented Feb 25, 2021

@emackey Thanks for the advice. I have tried Dassault's path tracer.
However, unfortunately, I could not determine if that was the correct result.

Dassault's path tracer + ToyCarSpecular.gltf(using the KHR_materials_specular extension) result:
image

Since this extension is not yet finished, we may have to work on another issue first.

@Reon90
Copy link
Owner

Reon90 commented Feb 26, 2021

@cx20 fixed in 2.5.13

@cx20
Copy link
Author

cx20 commented Feb 27, 2021

@Reon90 Thanks! It looks good.

result
before image
after image

@cx20 cx20 closed this as completed Feb 27, 2021
@cx20
Copy link
Author

cx20 commented Jun 1, 2021

@Reon90 The cloth seems dark when I view ToyCarSpecular.gltf on the latest version of RedCube. Can you confirm it?

result
RedCube 2.5.13 image
RedCube 3.0.2 image

@cx20 cx20 reopened this Jun 1, 2021
@Reon90
Copy link
Owner

Reon90 commented Mar 26, 2022

fixed in 3.2.0 @cx20

@Reon90
Copy link
Owner

Reon90 commented Apr 7, 2022

@cx20 could you check?

@Reon90 Reon90 closed this as completed Apr 16, 2022
@cx20
Copy link
Author

cx20 commented Apr 16, 2022

I have confirmed this model again with RedCube v3.3.0. I think the cloth is brighter than before.

image

@emackey Is it possible to determine if the brightness of this cloth is correct? Personally, I don't feel so uncomfortable, so I feel that the test has passed.

@emackey
Copy link

emackey commented Apr 16, 2022

@cx20 Let's disregard the cloth on this particular version of the ToyCar model. Fabric and sheen effects have other tests that have already been merged into the official repo. This version of ToyCar is due to be replaced eventually. Thanks.

@cx20
Copy link
Author

cx20 commented Apr 16, 2022

@emackey Thanks for the advice.

@Reon90 I would like to ignore the effects of Fabric and sheen as advised by emackey. I marked the test as passing in gltf-test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants