Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL 12 support #216

Closed
devrimgunduz opened this issue Sep 26, 2019 · 2 comments
Closed

PostgreSQL 12 support #216

devrimgunduz opened this issue Sep 26, 2019 · 2 comments

Comments

@devrimgunduz
Copy link

Hi,

v12 is out next week. When can we expect a new release that supports v12?

Below are the errors:

/usr/lib64/ccache/clang -Wno-ignored-attributes -fno-strict-aliasing -fwrapv -O2  -DREPACK_VERSION=1.4.4 -I. -I./ -I/usr/pgsql-12/include/server -I/usr/pgsql-12/include/internal  -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include -flto=thin -emit-llvm -c -o repack.bc repack.c
/usr/lib64/ccache/clang -Wno-ignored-attributes -fno-strict-aliasing -fwrapv -O2  -DREPACK_VERSION=1.4.4 -I. -I./ -I/usr/pgsql-12/include/server -I/usr/pgsql-12/include/internal  -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include -flto=thin -emit-llvm -c -o pgut/pgut-spi.bc pgut/pgut-spi.c
repack.c: In function 'repack_swap':
repack.c:116:39: error: too few arguments to function 'RenameRelationInternal'
  116 | #define RENAME_REL(relid, newrelname) RenameRelationInternal(relid, newrelname, true);
      |                                       ^~~~~~~~~~~~~~~~~~~~~~
repack.c:932:3: note: in expansion of macro 'RENAME_REL'
  932 |   RENAME_REL(reltoastrelid1, name);
      |   ^~~~~~~~~~
In file included from repack.c:38:
/usr/pgsql-12/include/server/commands/tablecmds.h:69:13: note: declared here
   69 | extern void RenameRelationInternal(Oid myrelid,
      |             ^~~~~~~~~~~~~~~~~~~~~~
repack.c:116:39: error: too few arguments to function 'RenameRelationInternal'
  116 | #define RENAME_REL(relid, newrelname) RenameRelationInternal(relid, newrelname, true);
      |                                       ^~~~~~~~~~~~~~~~~~~~~~
repack.c:934:3: note: in expansion of macro 'RENAME_REL'
  934 |   RENAME_REL(reltoastidxid1, name);
      |   ^~~~~~~~~~
In file included from repack.c:38:
/usr/pgsql-12/include/server/commands/tablecmds.h:69:13: note: declared here
   69 | extern void RenameRelationInternal(Oid myrelid,
      |             ^~~~~~~~~~~~~~~~~~~~~~
repack.c:116:39: error: too few arguments to function 'RenameRelationInternal'
  116 | #define RENAME_REL(relid, newrelname) RenameRelationInternal(relid, newrelname, true);
      |                                       ^~~~~~~~~~~~~~~~~~~~~~
repack.c:944:3: note: in expansion of macro 'RENAME_REL'
  944 |   RENAME_REL(reltoastrelid1, name);
      |   ^~~~~~~~~~
In file included from repack.c:38:
/usr/pgsql-12/include/server/commands/tablecmds.h:69:13: note: declared here
   69 | extern void RenameRelationInternal(Oid myrelid,
      |             ^~~~~~~~~~~~~~~~~~~~~~
repack.c:116:39: error: too few arguments to function 'RenameRelationInternal'
  116 | #define RENAME_REL(relid, newrelname) RenameRelationInternal(relid, newrelname, true);
      |                                       ^~~~~~~~~~~~~~~~~~~~~~
repack.c:946:3: note: in expansion of macro 'RENAME_REL'
  946 |   RENAME_REL(reltoastidxid1, name);
      |   ^~~~~~~~~~
In file included from repack.c:38:
/usr/pgsql-12/include/server/commands/tablecmds.h:69:13: note: declared here
   69 | extern void RenameRelationInternal(Oid myrelid,
      |             ^~~~~~~~~~~~~~~~~~~~~~
repack.c:116:39: error: too few arguments to function 'RenameRelationInternal'
  116 | #define RENAME_REL(relid, newrelname) RenameRelationInternal(relid, newrelname, true);
      |                                       ^~~~~~~~~~~~~~~~~~~~~~
repack.c:951:3: note: in expansion of macro 'RENAME_REL'
  951 |   RENAME_REL(reltoastrelid2, name);
      |   ^~~~~~~~~~
In file included from repack.c:38:
/usr/pgsql-12/include/server/commands/tablecmds.h:69:13: note: declared here
   69 | extern void RenameRelationInternal(Oid myrelid,
      |             ^~~~~~~~~~~~~~~~~~~~~~
repack.c:116:39: error: too few arguments to function 'RenameRelationInternal'
  116 | #define RENAME_REL(relid, newrelname) RenameRelationInternal(relid, newrelname, true);
      |                                       ^~~~~~~~~~~~~~~~~~~~~~
repack.c:953:3: note: in expansion of macro 'RENAME_REL'
  953 |   RENAME_REL(reltoastidxid2, name);
      |   ^~~~~~~~~~
In file included from repack.c:38:
/usr/pgsql-12/include/server/commands/tablecmds.h:69:13: note: declared here
   69 | extern void RenameRelationInternal(Oid myrelid,
      |             ^~~~~~~~~~~~~~~~~~~~~~
repack.c:116:39: error: too few arguments to function 'RenameRelationInternal'
  116 | #define RENAME_REL(relid, newrelname) RenameRelationInternal(relid, newrelname, true);
      |                                       ^~~~~~~~~~~~~~~~~~~~~~
repack.c:958:3: note: in expansion of macro 'RENAME_REL'
  958 |   RENAME_REL(reltoastrelid1, name);
      |   ^~~~~~~~~~
In file included from repack.c:38:
/usr/pgsql-12/include/server/commands/tablecmds.h:69:13: note: declared here
   69 | extern void RenameRelationInternal(Oid myrelid,
      |             ^~~~~~~~~~~~~~~~~~~~~~
repack.c:116:39: error: too few arguments to function 'RenameRelationInternal'
  116 | #define RENAME_REL(relid, newrelname) RenameRelationInternal(relid, newrelname, true);
      |                                       ^~~~~~~~~~~~~~~~~~~~~~
repack.c:960:3: note: in expansion of macro 'RENAME_REL'
  960 |   RENAME_REL(reltoastidxid1, name);
      |   ^~~~~~~~~~
In file included from repack.c:38:
/usr/pgsql-12/include/server/commands/tablecmds.h:69:13: note: declared here
   69 | extern void RenameRelationInternal(Oid myrelid,
      |             ^~~~~~~~~~~~~~~~~~~~~~
repack.c: In function 'swap_heap_or_index_files':
repack.c:1154:16: warning: implicit declaration of function 'heap_open' [-Wimplicit-function-declaration]
 1154 |  relRelation = heap_open(RelationRelationId, RowExclusiveLock);
      |                ^~~~~~~~~
repack.c:1154:14: warning: assignment to 'Relation' {aka 'struct RelationData *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
 1154 |  relRelation = heap_open(RelationRelationId, RowExclusiveLock);
      |              ^
repack.c:1317:2: warning: implicit declaration of function 'heap_close' [-Wimplicit-function-declaration]
 1317 |  heap_close(relRelation, RowExclusiveLock);
      |  ^~~~~~~~~~
make[2]: *** [<builtin>: repack.o] Error 1
make[2]: *** Waiting for unfinished jobs....
repack.c:932:3: error: too few arguments to function call, expected 4, have 3
                RENAME_REL(reltoastrelid1, name);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
repack.c:116:85: note: expanded from macro 'RENAME_REL'
#define RENAME_REL(relid, newrelname) RenameRelationInternal(relid, newrelname, true);
                                      ~~~~~~~~~~~~~~~~~~~~~~                        ^
/usr/pgsql-12/include/server/commands/tablecmds.h:69:1: note: 'RenameRelationInternal' declared here
extern void RenameRelationInternal(Oid myrelid,
^
repack.c:934:3: error: too few arguments to function call, expected 4, have 3
                RENAME_REL(reltoastidxid1, name);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
repack.c:116:85: note: expanded from macro 'RENAME_REL'
#define RENAME_REL(relid, newrelname) RenameRelationInternal(relid, newrelname, true);
                                      ~~~~~~~~~~~~~~~~~~~~~~                        ^
/usr/pgsql-12/include/server/commands/tablecmds.h:69:1: note: 'RenameRelationInternal' declared here
extern void RenameRelationInternal(Oid myrelid,
^
repack.c:944:3: error: too few arguments to function call, expected 4, have 3
                RENAME_REL(reltoastrelid1, name);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
repack.c:116:85: note: expanded from macro 'RENAME_REL'
#define RENAME_REL(relid, newrelname) RenameRelationInternal(relid, newrelname, true);
                                      ~~~~~~~~~~~~~~~~~~~~~~                        ^
/usr/pgsql-12/include/server/commands/tablecmds.h:69:1: note: 'RenameRelationInternal' declared here
extern void RenameRelationInternal(Oid myrelid,
^
repack.c:946:3: error: too few arguments to function call, expected 4, have 3
                RENAME_REL(reltoastidxid1, name);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
repack.c:116:85: note: expanded from macro 'RENAME_REL'
#define RENAME_REL(relid, newrelname) RenameRelationInternal(relid, newrelname, true);
                                      ~~~~~~~~~~~~~~~~~~~~~~                        ^
/usr/pgsql-12/include/server/commands/tablecmds.h:69:1: note: 'RenameRelationInternal' declared here
extern void RenameRelationInternal(Oid myrelid,
^
repack.c:951:3: error: too few arguments to function call, expected 4, have 3
                RENAME_REL(reltoastrelid2, name);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
repack.c:116:85: note: expanded from macro 'RENAME_REL'
#define RENAME_REL(relid, newrelname) RenameRelationInternal(relid, newrelname, true);
                                      ~~~~~~~~~~~~~~~~~~~~~~                        ^
/usr/pgsql-12/include/server/commands/tablecmds.h:69:1: note: 'RenameRelationInternal' declared here
extern void RenameRelationInternal(Oid myrelid,
^
repack.c:953:3: error: too few arguments to function call, expected 4, have 3
                RENAME_REL(reltoastidxid2, name);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
repack.c:116:85: note: expanded from macro 'RENAME_REL'
#define RENAME_REL(relid, newrelname) RenameRelationInternal(relid, newrelname, true);
                                      ~~~~~~~~~~~~~~~~~~~~~~                        ^
/usr/pgsql-12/include/server/commands/tablecmds.h:69:1: note: 'RenameRelationInternal' declared here
extern void RenameRelationInternal(Oid myrelid,
^
repack.c:958:3: error: too few arguments to function call, expected 4, have 3
                RENAME_REL(reltoastrelid1, name);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
repack.c:116:85: note: expanded from macro 'RENAME_REL'
#define RENAME_REL(relid, newrelname) RenameRelationInternal(relid, newrelname, true);
                                      ~~~~~~~~~~~~~~~~~~~~~~                        ^
/usr/pgsql-12/include/server/commands/tablecmds.h:69:1: note: 'RenameRelationInternal' declared here
extern void RenameRelationInternal(Oid myrelid,
^
repack.c:960:3: error: too few arguments to function call, expected 4, have 3
                RENAME_REL(reltoastidxid1, name);
                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
repack.c:116:85: note: expanded from macro 'RENAME_REL'
#define RENAME_REL(relid, newrelname) RenameRelationInternal(relid, newrelname, true);
                                      ~~~~~~~~~~~~~~~~~~~~~~                        ^
/usr/pgsql-12/include/server/commands/tablecmds.h:69:1: note: 'RenameRelationInternal' declared here
extern void RenameRelationInternal(Oid myrelid,
^
repack.c:1154:16: warning: implicit declaration of function 'heap_open' is invalid in C99 [-Wimplicit-function-declaration]
        relRelation = heap_open(RelationRelationId, RowExclusiveLock);
                      ^
repack.c:1154:14: warning: incompatible integer to pointer conversion assigning to 'Relation' (aka 'struct RelationData *') from 'int' [-Wint-conversion]
        relRelation = heap_open(RelationRelationId, RowExclusiveLock);
                    ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
repack.c:1317:2: warning: implicit declaration of function 'heap_close' is invalid in C99 [-Wimplicit-function-declaration]
        heap_close(relRelation, RowExclusiveLock);
        ^
3 warnings and 8 errors generated.

@Melkij
Copy link
Collaborator

Melkij commented Sep 26, 2019

Hello
Still waiting for #207 ..

@dvarrazzo
Copy link
Member

Released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants