Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track generator ID using RecordReplayObjectId #6

Closed
bhackett1024 opened this issue May 3, 2021 · 0 comments
Closed

Track generator ID using RecordReplayObjectId #6

bhackett1024 opened this issue May 3, 2021 · 0 comments

Comments

@bhackett1024
Copy link

We need to associate IDs with each generator object in order to support async stepping. Currently we do this by storing an integer in JSGeneratorObject which is accessed when starting/resuming generators, but the modification this makes to js-generator.tq seems to be causing frequent scavenger crashes. We have a separate, slower weak map from objects to IDs which we can use instead and avoid modifying this tq file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant