Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a stable value for function offsets #5

Closed
bhackett1024 opened this issue Mar 19, 2021 · 0 comments
Closed

Use a stable value for function offsets #5

bhackett1024 opened this issue Mar 19, 2021 · 0 comments

Comments

@bhackett1024
Copy link

Currently the offsets we use within functions is the index into the global array of instrumentation sites. This needs to be consistent in order for breakpoints in replay to work, which requires script compilation order to be consistent among recording and different replays. This isn't the case, and isn't something we can reasonably expect to enforce without running into problems --- compilation can be triggered by all sorts of non-deterministic VM activity. We should use bytecode offsets for function offsets instead, like we do in gecko.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant