Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devtools e2e perma-failures after 16.x rebase #78

Closed
bhackett1024 opened this issue May 19, 2022 · 1 comment
Closed

Devtools e2e perma-failures after 16.x rebase #78

bhackett1024 opened this issue May 19, 2022 · 1 comment

Comments

@bhackett1024
Copy link

Devtools e2e has started perma-failing after releasing a new version of node based on 16.x:

https://github.com/RecordReplay/devtools/actions/runs/2353796782

I looked at one recording and it looks like evaluations are failing:

https://app.replay.io/recording/replay-of-devtools-nf5vxx1f2-recordreplayvercelapp--dcd57557-9f81-4d5d-87b4-3be6f4d0f55f?point=38617707887746171743783085932544000&time=20359.512012012012&hasFrames=false

I'm going to roll back to the last version before the rebase for now.

@bhackett1024
Copy link
Author

I'm not sure why this was happening on node and not apparently other platforms, but I'm not able to reproduce it with the rebased node now. Looking at the controller log for the failed evaluation, I think the message hanged because of a busted assert in BatchedPromiseMap --- this recording was made when we had a bug mapping locations, since fixed by https://github.com/RecordReplay/backend/pull/5667. I'll try releasing the rebased node again and see if we continue to run into any problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant