Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CheckoutCheckpoint into separate experiment and checkpoint functions #478

Open
bfirsh opened this issue Jan 11, 2021 · 0 comments
Labels
help wanted Extra attention is needed type/chore Something not user-facing

Comments

@bfirsh
Copy link
Member

bfirsh commented Jan 11, 2021

CheckoutCheckpoint on the Project Go struct current serves two purposes:

  • Check out a checkpoint for Python API
  • Check out an experiment or checkpoint for CLI

There should be separate methods for checking out projects and checkpoints on Project. The business logic of choosing between an experiment and checkpoint, along with all the log output, should live in the CLI or somewhere else.

See also:

Follow-on of #408

@bfirsh bfirsh added help wanted Extra attention is needed type/chore Something not user-facing labels Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed type/chore Something not user-facing
Projects
None yet
Development

No branches or pull requests

1 participant