Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate replicate with Hugging Face transformers #498

Open
charlieyou opened this issue Jan 17, 2021 · 3 comments
Open

Integrate replicate with Hugging Face transformers #498

charlieyou opened this issue Jan 17, 2021 · 3 comments

Comments

@charlieyou
Copy link

Similar to Pytorch Lightning, Hugging Face abstracts away the training loop and provides a Trainer API with callbacks

I will probably be able to take this on in the next few weeks.

How are you thinking about keeping callbacks in this repo (for both this and previous ones (keras, PL)) vs contributing to those library repos like tensorboard and w&b do? Keep in here until a stable v1 release?

@bfirsh
Copy link
Member

bfirsh commented Jan 18, 2021

Nice, great idea! 🙌

We're going to contribute the PyTorch Lightning integration back to PyTorch Lightning. We included in our repository as a shortcut, because the integration needed changes to their callback API.

Looks like Hugging Face also include callbacks for services in their library, so it probably makes sense for it to live there. I wonder whether we should include it now or wait until our API is a bit more stable. I can imagine us being able to build in backwards compatibility if we ever change something.

As a place to develop it, I wonder if it makes sense to create a separate package? replicate-huggingface, or whatever. The intention would be to get it into Hugging Face, and the advantage of it being separate is it isn't something we have to remove from Replicate at some point, which is always messy. We can document it or link to it from https://replicate.ai so it gets eyeballs on it.

Also open to including it in Replicate-proper, but this might be a neater solution if we intend to contribute it upstream to Hugging Face at some point...

@bfirsh
Copy link
Member

bfirsh commented Jan 18, 2021

@srush Do you have any opinions about this, or know someone at Hugging Face who might? :)

@srush
Copy link

srush commented Jan 19, 2021

I will check!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants