Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing tag rule should not apply to local multistage Dockerfiles #187

Open
iskandersierra opened this issue Oct 6, 2021 · 6 comments
Open

Comments

@iskandersierra
Copy link

Using project mega-linter, I get the following error:

    Line 16: FROM build AS publish
    Issue  Category      Title                 Description
        1  Clarity       Base Image Missing    Base images should specify a tag to use.
                         Tag

on the following Dockerfile:

#See https://aka.ms/containerfastmode to understand how Visual Studio uses this Dockerfile to build your images for faster debugging.

FROM mcr.microsoft.com/dotnet/aspnet:5.0-buster-slim AS base
...

FROM mcr.microsoft.com/dotnet/sdk:5.0-buster-slim AS build
...

FROM build AS publish # This is the offender line
...

FROM base AS final # This is an offender line as well
...

This makes me disable the rule missing_tag, which I want enabled for the first two stages, in order to pass the test.

Is this behaviour intended or is it possible to check whether there is a previous stage with the name being checked and skip that validation?

Thanks for the good work. If you accept PRs I could check if I can do this update.

@sbollap1
Copy link

sbollap1 commented Dec 1, 2021

I had similar issue, here the link to it. oxsecurity/megalinter#1053 curious if you have a workaround

@tymonx
Copy link

tymonx commented Jan 4, 2022

I have the same issue here for local multi stages. It would be nice to have a general option to disable any rule(s) using comment #dockerfilelint disable=missing_tag.

@ankitbko
Copy link

ankitbko commented Mar 7, 2022

Any update on this?

@jamescanady
Copy link

I just ran into the same issue.

@johbo
Copy link

johbo commented Nov 23, 2022

Just did bump into the same issue, is there really no way to add an ignore statement like the one suggested above? This would help to "workaround" the problem until it will eventually be supported.

Currently I end up disabling the linter for a whole file, and that's sad because we loose valuable feedback from it.

@skull-squadron
Copy link

Just encountered this 2.5 years later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants