mongodb-replicaset stable helm chart fails to rewrite all images

[emosbaugh]

mongodb-replicaset stable helm chart fails to rewrite all images

the chart contains a pod resource

https://github.com/helm/charts/blob/88a5176022e8dda60a498d2b8953a9feb3d13b0b/stable/mongodb-replicaset/templates/tests/mongodb-up-test-pod.yaml#L1-L2

Image rewriting does not work with pods

kots/pkg/image/builder.go

Lines 247 to 278 in 82a9f98

	func listImagesInFile(contents []byte, handler processImagesFunc) error {
	yamlDocs := bytes.Split(contents, []byte("\n---\n"))
	for _, yamlDoc := range yamlDocs {
	parsed := &k8sdoc.Doc{}
	if err := yaml.Unmarshal(yamlDoc, parsed); err != nil {
	continue
	}
	images := make([]string, 0)
	for _, container := range parsed.Spec.Template.Spec.Containers {
	images = append(images, container.Image)
	}
	for _, container := range parsed.Spec.Template.Spec.InitContainers {
	images = append(images, container.Image)
	}
	for _, container := range parsed.Spec.JobTemplate.Spec.Template.Spec.InitContainers {
	images = append(images, container.Image)
	}
	for _, container := range parsed.Spec.JobTemplate.Spec.Template.Spec.Containers {
	images = append(images, container.Image)
	}
	if err := handler(images, parsed); err != nil {
	return err
	}
	}
	return nil
	}

kots/pkg/midstream/write.go

Lines 226 to 236 in 82a9f98

	default:
	newObj.Spec = k8sdoc.Spec{
	Template: k8sdoc.Template{
	Spec: k8sdoc.PodSpec{
	ImagePullSecrets: []k8sdoc.ImagePullSecret{
	{"name": "kotsadm-replicated-registry"},
	},
	},
	},
	}
	}