Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other S3-Compatible Storage in Snapshots Settings does not work #828

Closed
sgalsaleh opened this issue Jul 22, 2020 · 0 comments · Fixed by #914
Closed

Other S3-Compatible Storage in Snapshots Settings does not work #828

sgalsaleh opened this issue Jul 22, 2020 · 0 comments · Fixed by #914
Labels
type::bug Something isn't working
Milestone

Comments

@sgalsaleh
Copy link
Member

In the Snapshots Settings page, when selecting the Other S3-Compatible Storage option and providing all of: Bucket, Access Key ID, Access Key Secret, Endpoint and a Region and clicking Update settings, the page shows “Settings updated”, but the screen then switches to the Amazon S3 option and creating snapshots fails.

I think i've identified two issues that are related to this:

1- The credentials secret for Other S3-Compatible Storage is not created/updated https://github.com/replicatedhq/kots/blob/5407de9e/kotsadm/pkg/snapshot/store.go#L153

2- The provider for Other S3-Compatible Storage is passed as other from Kotsadm and is saved as is: https://github.com/replicatedhq/kots/blob/fa9f1049/kotsadm/pkg/handlers/snapshots.go#L104
But then, when reading the store information for it, the code checks for aws https://github.com/replicatedhq/kots/blob/5407de9e/kotsadm/pkg/snapshot/store.go#L378
which i think is the cause for switching to the Amazon S3 option after the settings are updated.

@sgalsaleh sgalsaleh added the type::bug Something isn't working label Jul 22, 2020
@sgalsaleh sgalsaleh added this to the 1.18.0 milestone Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type::bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant