-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'copy' collector should work with directories #212
Comments
Hi @laverya @markpundsack, I found a solution that would allow copy collector to get all the files in a folder and its sub-folders. But, should it have a limit? Should we not copy some specific type of file? |
I don’t have any strong opinions on this. Being able to specify a pattern sounds useful too, but I do imagine some people will need to simply copy a entire directory, knowing that it only contains the kind of files they are looking for. |
@markpundsack Sound good! I've created the PR with the modifications! Let me know if there is something you would like to change! |
@manavellamnimble @divolgin Did the changes include documentation? |
@markpundsack @divolgin I was about to ask about this in the chat! If you want I can ask about it on slack, so we are all in the same page |
@manavellamnimble Great, go ahead and coordinate in Slack. |
Currently the copy collector calls cat within the container, which doesn't work with directories - only individual files. This is rather suboptimal.
The text was updated successfully, but these errors were encountered: