Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'copy' collector should work with directories #212

Closed
laverya opened this issue Jun 4, 2020 · 6 comments · Fixed by #237
Closed

'copy' collector should work with directories #212

laverya opened this issue Jun 4, 2020 · 6 comments · Fixed by #237
Labels
good first issue Good for newcomers type::feature New feature or request

Comments

@laverya
Copy link
Member

laverya commented Jun 4, 2020

Currently the copy collector calls cat within the container, which doesn't work with directories - only individual files. This is rather suboptimal.

@laverya laverya added the type::feature New feature or request label Jun 4, 2020
@markpundsack markpundsack added the good first issue Good for newcomers label Jul 28, 2020
@manavellamnimble
Copy link
Contributor

Hi @laverya @markpundsack, I found a solution that would allow copy collector to get all the files in a folder and its sub-folders. But, should it have a limit? Should we not copy some specific type of file?

@markpundsack
Copy link
Contributor

I don’t have any strong opinions on this. Being able to specify a pattern sounds useful too, but I do imagine some people will need to simply copy a entire directory, knowing that it only contains the kind of files they are looking for.

@manavellamnimble
Copy link
Contributor

@markpundsack Sound good! I've created the PR with the modifications! Let me know if there is something you would like to change!

@markpundsack
Copy link
Contributor

@manavellamnimble @divolgin Did the changes include documentation?

@manavellamnimble
Copy link
Contributor

@markpundsack @divolgin I was about to ask about this in the chat! If you want I can ask about it on slack, so we are all in the same page

@markpundsack
Copy link
Contributor

@manavellamnimble Great, go ahead and coordinate in Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type::feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants