Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinKNOW/Guppy update needs new model for R10.4.1 5 kHz #254

Closed
hoelzer opened this issue May 24, 2023 · 6 comments · Fixed by #255
Closed

MinKNOW/Guppy update needs new model for R10.4.1 5 kHz #254

hoelzer opened this issue May 24, 2023 · 6 comments · Fixed by #255
Assignees
Labels
enhancement New feature or request

Comments

@hoelzer
Copy link
Collaborator

hoelzer commented May 24, 2023

In a recent MinKNOW/Guppy (v6.5.7) update, the sampling rate for R10.4.1 FCs was increased from 4 kHz to 5 kHz. In Guppy (v6.5.7), there is a new model for 5 kHz: DNA r10.4.1 e8.2 400bps 5khz

The corresponding Medaka v1.8.0 model for 5 kHz data is

r1041_e82_400bps_sup_v4.2.0

In the current ARTIC container we are using, Medaka is v1.7.2. Thus, I created a new ARTIC container w/ Medaka v1.8.0 and the most recent models:

nanozoo/artic:1.3.0-dev--e22cdbc

I suggest, after testing, adding that new container to the pipeline also to allow variant calling with recent Medaka models.

@MarieLataretu
Copy link
Collaborator

Thanks, @hoelzer!

The medaka processes fail at the moment, because keras_preprocessing is not found:
ModuleNotFoundError: No module named 'keras_preprocessing'

I added the full err file:
tmp_medaka.err.txt

@hoelzer
Copy link
Collaborator Author

hoelzer commented May 26, 2023

Hey, thanks for testing @MarieLataretu !

Hm, I did not change anything else besides the Medaka version and everything installed successfully according to conda.

I can try to add a

conda install -c conda-forge keras-preprocessing

to the container build.

@MarieLataretu
Copy link
Collaborator

yeah, let's give it a try!

@hoelzer
Copy link
Collaborator Author

hoelzer commented May 26, 2023

@MarieLataretu

docker pull nanozoo/artic:1.3.0-dev--784493e

@hoelzer
Copy link
Collaborator Author

hoelzer commented May 26, 2023

And I deleted already the non-working container nanozoo/artic:1.3.0-dev--e22cdbc

@MarieLataretu
Copy link
Collaborator

perfect, nanozoo/artic:1.3.0-dev--784493e worked!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants