Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting rules colliding with Intellij auto-formatting #249

Closed
TimoKramer opened this issue Oct 27, 2020 · 5 comments
Closed

Formatting rules colliding with Intellij auto-formatting #249

TimoKramer opened this issue Oct 27, 2020 · 5 comments
Assignees

Comments

@TimoKramer
Copy link
Member

There is a problem with auto-formatting on Intellij on let-bindings. Is there a setting in Intellij to avoid that?

@jsmassa
Copy link
Collaborator

jsmassa commented Oct 28, 2020

How do you set the formatting rules to comply with our guidelines in general?

I have only found the standard Intellij way via settings->editor->codestyle->clojure. I couldn't find the right settings to comply with our guidelines though. But it looks like you can set the indentation for different core functions under the tab "Form Parameters".

@TimoKramer
Copy link
Member Author

Currently it is default cljfmt formatting and there is nothing specified though this is possible. I heard that Intellij is formatting differently especially the let-bindings and I wanted to know from Intellij-users if this can be adjusted to not having a lot of reformatting in the PRs. I don't know where this reformatting was that @kordano mentioned.

Either the intellij-users set the formatting for the let-bindings in their IDE or we need to specifiy the formatting rule in cljfmt and reformat all again. It would be cumbersome for reviewers to have PRs doing the reformatting here and there, I guess.

@TimoKramer
Copy link
Member Author

discussion on this in the clojure style guide that we follow so far

@jsmassa
Copy link
Collaborator

jsmassa commented Nov 2, 2020

Ah, ok, that's the formatting you mean... And yes, the forcing of alignment of let binding values can be turned off and on in settings as well in Intellij

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants