Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary dependencies #31

Closed
whilo opened this issue Mar 26, 2019 · 5 comments
Closed

Remove unnecessary dependencies #31

whilo opened this issue Mar 26, 2019 · 5 comments
Assignees
Labels
enhancement New feature or request
Projects
Milestone

Comments

@whilo
Copy link
Member

whilo commented Mar 26, 2019

Currently datahike automatically pulls in ClojureScript, timbre, guava and a few other things. We should make these dependencies optional by going through our stack. This will also make it easier to have datahike run on GraalVM. @borkdude

@kordano
Copy link
Member

kordano commented Mar 26, 2019

With the rebase I started cleaning and updating the dependencies too. Maybe we should also clean up the deps in our other libraries like konserve or hitchhiker tree.

@kordano kordano added the enhancement New feature or request label Mar 26, 2019
@kordano kordano added this to To do in Development via automation Mar 26, 2019
@borkdude
Copy link

I think stripping unnecessary deps is always a good thing, but I'm not sure if this will speed up GraalVM compilation.

@whilo
Copy link
Member Author

whilo commented Mar 27, 2019

With the rebase I started cleaning and updating the dependencies too. Maybe we should also clean up the deps in our other libraries like konserve or hitchhiker tree.

Yes, definitely. That is what I thought. My take is to declare the dependencies with :scope-provided in leiningen, but I guess it is better to move to deps.edn? I am a bit out of date with respect to current tooling.

@kordano
Copy link
Member

kordano commented Mar 27, 2019

Agreed, we should try it with deps.edn.

@kordano kordano added this to the 0.2.0 milestone Mar 29, 2019
@kordano
Copy link
Member

kordano commented Mar 29, 2019

with the datascript rebase we have a deps.edn as a starting point: https://github.com/replikativ/datahike/blob/28-datascript-rebase/deps.edn

@kordano kordano moved this from To do to Reviewer approved in Development Sep 17, 2019
@kordano kordano moved this from Reviewer approved to Done in Development Sep 17, 2019
@kordano kordano closed this as completed Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development
  
Done
Development

No branches or pull requests

4 participants