Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 684: Make it possible to compare values of different types #685

Merged
merged 1 commit into from
Jun 23, 2024

Conversation

jonasseglare
Copy link
Collaborator

Fixes #684

SUMMARY

Makes it possible to run queries that require comparing values of different types, such as numbers and strings. The exact order between values of different types is not important, as long as it is consistent and well-defined.

Checks

Bugfix
  • Related issues linked using fixes #number
  • Integration tests added
  • Architecture Decision Record added if design changes necessary
  • Formatting checked
Feature
  • Implements an existing feature request. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Architecture Decision Record added
  • Formatting checked

Copy link
Member

@whilo whilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@whilo whilo merged commit 0e4002a into main Jun 23, 2024
10 checks passed
@whilo whilo deleted the issue684-safe-compare branch June 23, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Comparisons in queries fail when mixing values of different types
2 participants