Feature Request: A search feature to select issuer/label

[brian6932]

I think a useful feature would be to be able to do a find search to select issuer/label with ctrl + f and/or /

Also one minor thing:
I think it would be nice if k were moved off this bind:
k -> Show QRCode of the selected element
and instead using k/j as vim alts for ↑/↓ would be better/more universal imo

[replydev]

Hi, i also think that a search feature could be useful, this commit d7b4a0c includes a draft.
I want to improve the search UI, but for now let me know your impressions.

Thanks, regards.

[brian6932]

Nice, I like that esc lets me exit out of the find without exiting out of the whole program.
So my nitpicks would be:

1. I don't like that when you use find the whole screen gets taken up. If possible, I think it would be nice to put it in a margin/overlay, maybe over the cotp v0.2.0 text, or below the progress bar.

For example, this is how bottom does it:
https://i.nuuls.com/xgp3h.png

2. This is probably more annoying to do, but while using find, it should instead of only grabbing item on enter, track to closest item you're typing, with like a contains/similarity, and highlight them accordingly as you type. While only actually copying the item on enter. Since esc is already an exit for find, double enter seems unnecessary (as long as there is an overlay/margin like I mentioned in 1.).

[replydev]

This 7702bd6 is quite better.

[brian6932]

Nice, much better. Now there's really only this nitpick:

2. This is probably more annoying to do, but while using find, it should instead of only grabbing item on enter, track to closest item you're typing, with like a contains/similarity, and highlight them accordingly as you type. While only actually copying the item on enter. Since esc is already an exit for find, double enter seems unnecessary.

[replydev]

Yeah you are right. 0f8fa30 this could be the final step. Let me know.

Thank you, regards

[brian6932]

Perfect!
The only minor nitpick I could have is that the search box should support either, ctrl + w and/or ctrl + backspace, for deleting the whole word

[replydev]

The only minor nitpick I could have is that the search box should support either, ctrl + w and/or ctrl + backspace, for deleting the whole word

Done with CTRL-W. Thank you for your advices.

[brian6932]

ctrl w/backspace is typically for single word deletion, but this is close enough, Ty for being so receptive ❤️