This repository has been archived by the owner on Aug 21, 2021. It is now read-only.
/
clustered_storage.go
694 lines (606 loc) · 17.4 KB
/
clustered_storage.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
package service
import (
"database/sql"
"fmt"
"io"
"math"
"net/http"
"os"
"path"
"strconv"
"sync"
_ "github.com/mattn/go-sqlite3"
"github.com/pkg/errors"
"github.com/sirupsen/logrus"
"repospanner.org/repospanner/server/storage"
)
const maxAttempts = 3
var errDupeObject = errors.New("clustered_storage: Duplicated object ignored")
type clusterStorageDriverInstance struct {
inner storage.StorageDriver
cfg *Service
}
func (d *clusterStorageDriverInstance) GetProjectStorage(project string) storage.ProjectStorageDriver {
return &clusterStorageProjectDriverInstance{
d: d,
project: project,
inner: d.inner.GetProjectStorage(project),
}
}
type clusterStorageProjectDriverInstance struct {
d *clusterStorageDriverInstance
project string
inner storage.ProjectStorageDriver
}
type objectPusherInfo struct {
objid storage.ObjectID
reschan chan bool
}
type clusterStorageProjectPushDriverInstance struct {
d *clusterStorageProjectDriverInstance
pushuuid string
errchan chan error
outstandingobjects *sync.WaitGroup
objectSyncMux *sync.Mutex
objectSyncPeers []uint64
objectSyncDBPath string
objectSyncDB *sql.DB
objectSyncAllSubmitted bool
objectSyncNewObjects *sync.Cond
syncersWg *sync.WaitGroup
}
type clusterStorageDriverObject struct {
driver *clusterStorageProjectDriverInstance
objectid storage.ObjectID
sourcenode uint64
staged storage.StagedObject
body io.ReadCloser
}
type clusterStorageDriverStagedObject struct {
driver *clusterStorageProjectPushDriverInstance
inner storage.StagedObject
}
func (o *clusterStorageDriverObject) Read(p []byte) (in int, err error) {
in, err = o.body.Read(p)
if err != nil && err != io.EOF {
return
}
if in > 0 {
var out int
var outerr error
out, outerr = o.staged.Write(p[:in])
if outerr != nil {
return in, outerr
}
if in != out {
return in, errors.Errorf("Invalid number of bytes staged while streaming: %d != %d",
in,
out,
)
}
}
if err == io.EOF {
// End of object, finalize
_, err = o.staged.Finalize(o.objectid)
if err != nil {
return in, err
}
return in, io.EOF
}
return
}
func (o *clusterStorageDriverObject) Close() error {
return o.staged.Close()
}
func (d *clusterStorageProjectDriverInstance) tryObjectFromNode(objectid storage.ObjectID, nodeid uint64) (storage.ObjectType, uint, io.ReadCloser, error) {
if nodeid == d.d.cfg.nodeid || nodeid == 0 {
return storage.ObjectTypeBad, 0, nil, storage.ErrObjectNotFound
}
objecturl := d.d.cfg.GetPeerURL(nodeid, "/rpc/object/single/"+d.project+".git/"+string(objectid))
logger := d.d.cfg.log.WithFields(logrus.Fields{
"project": d.project,
"objectid": objectid,
"peer": nodeid,
"url": objecturl,
})
logger.Debug("Trying to get object from peer")
var resp *http.Response
attempt := 1
for resp == nil {
var err error
resp, err = d.d.cfg.rpcClient.Get(objecturl)
if err != nil {
if attempt < maxAttempts {
// Retry
attempt++
if attempt >= maxAttempts {
return storage.ObjectTypeBad, 0, nil, err
}
logger.WithError(err).Debugf("Failed, retrying %d/%d", attempt, maxAttempts)
continue
}
return storage.ObjectTypeBad, 0, nil, err
}
if resp.StatusCode == http.StatusNotFound {
resp.Body.Close()
return storage.ObjectTypeBad, 0, nil, storage.ErrObjectNotFound
}
if resp.StatusCode != http.StatusOK {
resp.Body.Close()
return storage.ObjectTypeBad, 0, nil, errors.Errorf("Status code: %d, status message: %s",
resp.StatusCode,
resp.Status,
)
}
}
// We got an object! Stream and store
logger.Debug("Peer returned object")
objtypes, hasobjtype := resp.Header["X-Objecttype"]
if !hasobjtype || len(objtypes) != 1 {
resp.Body.Close()
return storage.ObjectTypeBad, 0, nil, errors.New("No ObjectType header returned")
}
objtype := storage.ObjectTypeFromHdrName(objtypes[0])
objsizes, hasobjsize := resp.Header["X-Objectsize"]
if !hasobjsize || len(objsizes) != 1 {
resp.Body.Close()
return storage.ObjectTypeBad, 0, nil, errors.New("No ObjectSize header returned")
}
objsize := objsizes[0]
objsizei, err := strconv.ParseUint(objsize, 10, 64)
if err != nil {
resp.Body.Close()
return storage.ObjectTypeBad, 0, nil, err
}
// TODO: On Close, handle the pusher results for non-tree drivers
pusher := d.inner.GetPusher("")
staged, err := pusher.StageObject(objtype, uint(objsizei))
if err != nil {
resp.Body.Close()
return storage.ObjectTypeBad, 0, nil, err
}
logger.Debug("Streaming object from peer")
return objtype, uint(objsizei), &clusterStorageDriverObject{
driver: d,
objectid: objectid,
sourcenode: nodeid,
staged: staged,
body: resp.Body,
}, nil
}
type clusteredStorageNoLister int
func (d *clusterStorageProjectDriverInstance) ListObjects() storage.ProjectStorageObjectLister {
return clusteredStorageNoLister(42)
}
func (l clusteredStorageNoLister) Objects() <-chan storage.ObjectID {
c := make(chan storage.ObjectID)
close(c)
return c
}
func (l clusteredStorageNoLister) Err() error {
return errors.New("Clustered storage driver cannot list objects")
}
func (d *clusterStorageProjectDriverInstance) ReadObject(objectid storage.ObjectID) (storage.ObjectType, uint, io.ReadCloser, error) {
logger := d.d.cfg.log.WithFields(logrus.Fields{
"objectid": objectid,
"project": d.project,
})
objtype, objsize, reader, err := d.inner.ReadObject(objectid)
if err == storage.ErrObjectNotFound {
// Okay, now we get to perform our clustered magic
// First try at the node that got the last push for this project.
// We are hopeful that it will be the most up-to-date
primarypeer := d.d.cfg.statestore.GetLastPushNode(d.project)
objtype, objsize, reader, err := d.tryObjectFromNode(objectid, primarypeer)
if err == nil {
return objtype, objsize, reader, err
} else if err != storage.ErrObjectNotFound {
logger.WithError(err).Info("Error retrieving object from primary peer")
}
// If that didn't have the object (or crashed), fall back
for k := range d.d.cfg.statestore.Peers {
objtype, objsize, reader, err := d.tryObjectFromNode(objectid, k)
if err == nil {
return objtype, objsize, reader, err
} else if err != storage.ErrObjectNotFound {
logger.WithError(err).Info("Error retrieving object from peer")
}
}
logger.Info("Requested object could not be found at any peer")
return storage.ObjectTypeBad, 0, nil, storage.ErrObjectNotFound
}
// The underlying driver gave something that's not NoObject, return
return objtype, objsize, reader, err
}
func (d *clusterStorageProjectPushDriverInstance) pushSingleObject(peerid uint64, objid storage.ObjectID) error {
return d.d.d.cfg.syncSingleObject(
peerid,
d.d.inner,
d.d.project,
objid,
)
}
func (d *clusterStorageProjectPushDriverInstance) runPeerSyncer(peerid uint64) {
d.syncersWg.Add(1)
defer d.syncersWg.Done()
mylog := d.d.d.cfg.log.WithFields(logrus.Fields{
"pushuuid": d.pushuuid,
"syncpeer": peerid,
})
var retryfile *os.File
retrydir := path.Join(
d.d.d.cfg.statestore.directory,
"async-outqueues",
"peer-"+strconv.FormatUint(peerid, 16),
)
retryfilename := path.Join(
retrydir,
d.pushuuid,
)
mylog.Debug("Starting peer syncer")
for {
nextentry, err := d.dbGetNextObject(peerid)
if err != nil {
d.errchan <- err
return
}
mylog.Debug("Attempted to get an entry to sync")
if nextentry == storage.ZeroID {
// Nothing in the queue for us at this moment
d.objectSyncNewObjects.L.Lock()
if d.objectSyncAllSubmitted {
d.objectSyncNewObjects.L.Unlock()
mylog.Debug("We have synced everything out")
// We have been told we are all done.
if retryfile != nil {
// If we still had any entries we need to retry, rename the retryfile
err := retryfile.Close()
if err != nil {
mylog.WithError(err).Info("Error storing async retry queue")
return
}
err = os.Rename(retryfilename+".inprogress", retryfilename)
if err != nil {
mylog.WithError(err).Info("Error renaming async retry queue")
return
}
}
return
}
// We have no object right now, but more might be inbound.
// Wait until we get notified the queues have changed, and then retry
mylog.Debug("Nothing to sync out, but not done. Wait")
d.objectSyncNewObjects.Wait()
d.objectSyncNewObjects.L.Unlock()
mylog.Debug("We were kicked")
continue
}
mylog := mylog.WithField("objectid", nextentry)
mylog.Debug("Pushing single object to peer")
res := d.pushSingleObject(peerid, nextentry)
mylog.Debug("Results are in", "result", res)
if res == nil {
mylog.Debug("Object synced")
} else {
mylog.WithError(err).Info("Error during object sync")
if retryfile == nil {
if _, err := os.Stat(retrydir); os.IsNotExist(err) {
err := os.MkdirAll(retrydir, 0755)
if err != nil {
mylog.WithError(err).Info("Error creating retry dir")
break
}
}
var err error
retryfile, err = os.Create(retryfilename + ".inprogress")
if err != nil {
mylog.WithError(err).Info("Error creating retry file")
retryfile = nil
} else {
fmt.Fprintf(retryfile, "project:%s\n", d.d.project)
}
}
if retryfile != nil {
fmt.Fprintln(retryfile, nextentry)
}
mylog.WithError(res).Info("Error syncing object to peer, queued for async")
}
err = d.dbReportObject(nextentry, peerid, res == nil)
if err != nil {
d.errchan <- err
}
}
}
func (d *clusterStorageProjectPushDriverInstance) dbPrepare() error {
_, err := d.objectSyncDB.Exec(
`CREATE TABLE syncstatus (
objectid TEXT PRIMARY KEY NOT NULL,
alerted INTEGER NOT NULL,
neededpeers INTEGER NOT NULL,
outstanding INTEGER NOT NULL
)`,
)
if err != nil {
return err
}
_, err = d.objectSyncDB.Exec(
`CREATE UNIQUE INDEX objididx ON syncstatus (objectid)`,
)
if err != nil {
return err
}
return nil
}
func (d *clusterStorageProjectPushDriverInstance) dbPeerColumn(peerid uint64) string {
return "node_" + strconv.Itoa(int(peerid)) + "_queue"
}
func (d *clusterStorageProjectPushDriverInstance) dbAddPeer(peerid uint64) error {
_, err := d.objectSyncDB.Exec(
`CREATE TABLE ` + d.dbPeerColumn(peerid) + ` (objectid TEXT PRIMARY KEY NOT NULL)`,
)
d.objectSyncPeers = append(d.objectSyncPeers, peerid)
return err
}
func (d *clusterStorageProjectPushDriverInstance) dbAddObject(objid storage.ObjectID) error {
d.objectSyncMux.Lock()
defer d.objectSyncMux.Unlock()
numpeers := len(d.objectSyncPeers)
neededpeers := int(math.Floor(float64(numpeers+1) / 2.0))
tx, err := d.objectSyncDB.Begin()
if err != nil {
return err
}
res, err := tx.Exec(
`INSERT OR IGNORE INTO syncstatus (objectid, alerted, neededpeers, outstanding) VALUES ($1, 0, $2, $3)`,
objid,
neededpeers,
numpeers,
)
if err != nil {
tx.Rollback()
return err
}
aff, err := res.RowsAffected()
if err != nil {
tx.Rollback()
return err
}
if aff == 0 {
// This can happen if a client sends the same object twice in the same push.
// We can ignore the second one.
d.d.d.cfg.log.WithFields(logrus.Fields{
"objid": objid,
"neededpeers": neededpeers,
"numpeers": numpeers,
}).Debug("Duplicated object sent and ignored")
tx.Rollback()
return errDupeObject
}
d.d.d.cfg.log.WithFields(logrus.Fields{
"objid": objid,
"neededpeers": neededpeers,
"numpeers": numpeers,
}).Debug("Inserted object into syncstatus")
for _, peerid := range d.objectSyncPeers {
_, err := tx.Exec(
`INSERT INTO `+d.dbPeerColumn(peerid)+` (objectid) VALUES ($1)`,
objid,
)
if err != nil {
tx.Rollback()
return err
}
}
err = tx.Commit()
d.d.d.cfg.log.Debug("Kicking syncers")
d.objectSyncNewObjects.Broadcast()
d.d.d.cfg.log.Debug("Syncers kicked")
return err
}
func (d *clusterStorageProjectPushDriverInstance) dbGetNextObject(nodeid uint64) (storage.ObjectID, error) {
d.objectSyncMux.Lock()
defer d.objectSyncMux.Unlock()
tx, err := d.objectSyncDB.Begin()
if err != nil {
return storage.ZeroID, err
}
row := tx.QueryRow("SELECT objectid FROM " + d.dbPeerColumn(nodeid) + " LIMIT 1")
var objidS string
err = row.Scan(&objidS)
if err == sql.ErrNoRows {
tx.Rollback()
return storage.ZeroID, nil
}
if err != nil {
tx.Rollback()
return storage.ZeroID, err
}
res, err := tx.Exec(
`DELETE FROM `+d.dbPeerColumn(nodeid)+` WHERE objectid=$1`, objidS,
)
if err != nil {
tx.Rollback()
return storage.ZeroID, err
}
aff, err := res.RowsAffected()
if err != nil {
tx.Rollback()
return storage.ZeroID, err
}
if aff != 1 {
tx.Rollback()
return storage.ZeroID, errors.Errorf("Invalid number of rows affected in delete: %d != 1", aff)
}
return storage.ObjectID(objidS), tx.Commit()
}
func (d *clusterStorageProjectPushDriverInstance) dbReportObject(objid storage.ObjectID, nodeid uint64, success bool) error {
d.d.d.cfg.log.Debug("Starting report")
d.objectSyncMux.Lock()
defer d.objectSyncMux.Unlock()
d.d.d.cfg.log.Debug("Got locks report")
tx, err := d.objectSyncDB.Begin()
if err != nil {
return err
}
row := tx.QueryRow(
"SELECT alerted,neededpeers,outstanding FROM syncstatus WHERE objectid=$1",
objid,
)
var alerted, neededpeers, outstanding int
err = row.Scan(&alerted, &neededpeers, &outstanding)
if err != nil {
tx.Rollback()
return err
}
outstanding--
if success {
neededpeers--
}
if alerted == 1 {
// We have already notified people of the result of this object push
tx.Rollback()
return nil
}
if neededpeers <= 0 {
// We have reached low enough
d.d.d.cfg.log.Debug("Required number of peers synced")
d.outstandingobjects.Done()
alerted = 1
} else if outstanding < neededpeers {
// We still need more successes than we will ever get (happens if too many peers fail sync)
d.d.d.cfg.log.Info("Impossible to get to needed number of peers now")
d.errchan <- errors.Errorf(
"Too many nodes fail. Needed: %d, outstanding: %d",
neededpeers,
outstanding,
)
d.outstandingobjects.Done()
alerted = 1
}
res, err := tx.Exec(
`UPDATE syncstatus SET alerted=$1,neededpeers=$2,outstanding=$3 WHERE objectid=$4`,
alerted,
neededpeers,
outstanding,
objid,
)
if err != nil {
tx.Rollback()
return err
}
aff, err := res.RowsAffected()
if err != nil {
tx.Rollback()
return err
}
if aff != 1 {
tx.Rollback()
return errors.Errorf("Invalid number of rows affected in update: %d != 1", aff)
}
err = tx.Commit()
if err != nil {
return err
}
return nil
}
func (d *clusterStorageProjectDriverInstance) GetPusher(pushuuid string) storage.ProjectStoragePushDriver {
dbpath := path.Join(d.d.cfg.statestore.directory, "objectsyncs", pushuuid) + ".db"
db, err := sql.Open(
"sqlite3",
"file:"+dbpath+"?cache=shared&mode=memory",
)
if err != nil {
panic(err)
}
if err := db.Ping(); err != nil {
panic(err)
}
inst := &clusterStorageProjectPushDriverInstance{
d: d,
errchan: make(chan error),
outstandingobjects: new(sync.WaitGroup),
pushuuid: pushuuid,
objectSyncAllSubmitted: false,
objectSyncPeers: make([]uint64, 0),
objectSyncMux: new(sync.Mutex),
objectSyncDBPath: dbpath,
objectSyncDB: db,
objectSyncNewObjects: sync.NewCond(new(sync.Mutex)),
syncersWg: new(sync.WaitGroup),
}
if err := inst.dbPrepare(); err != nil {
panic(err)
}
syncwg := new(sync.WaitGroup)
for peerid := range d.d.cfg.statestore.Peers {
if peerid != d.d.cfg.statestore.NodeID {
syncwg.Add(1)
inst.dbAddPeer(peerid)
go func(peerid uint64) {
syncwg.Done()
inst.runPeerSyncer(peerid)
}(peerid)
}
}
syncwg.Wait()
return inst
}
func (d *clusterStorageProjectPushDriverInstance) StageObject(objtype storage.ObjectType, objsize uint) (storage.StagedObject, error) {
// For writing, just write directly to underlying storage
// TODO: Handle recursive non-tree pusher
pusher := d.d.inner.GetPusher(d.pushuuid)
inner, err := pusher.StageObject(objtype, objsize)
return &clusterStorageDriverStagedObject{
driver: d,
inner: inner,
}, err
}
func (d *clusterStorageProjectPushDriverInstance) GetPushResultChannel() <-chan error {
return d.errchan
}
func (d *clusterStorageProjectPushDriverInstance) Done() {
go func() {
d.d.d.cfg.log.Debug("Marking pusher as done")
d.objectSyncAllSubmitted = true
d.objectSyncNewObjects.Broadcast()
d.d.d.cfg.log.Debug("Told syncers we submitted everything")
d.outstandingobjects.Wait()
d.d.d.cfg.log.Debug("Required set of nodes have objects")
close(d.errchan)
d.d.d.cfg.log.Debug("Syncer is done")
go func(waiter *sync.WaitGroup) {
// Make sure we only close the database after all syncers are done with it
waiter.Wait()
d.objectSyncDB.Close()
os.Remove(d.objectSyncDBPath)
d.d.d.cfg.log.Debug("Syncer removed DB")
}(d.syncersWg)
}()
}
func (d *clusterStorageProjectPushDriverInstance) startObjectSync(objid storage.ObjectID) {
if len(d.objectSyncPeers) != 0 {
d.outstandingobjects.Add(1)
err := d.dbAddObject(objid)
if err == errDupeObject {
d.outstandingobjects.Done()
return
}
if err != nil {
panic(err)
}
}
}
func (o *clusterStorageDriverStagedObject) Write(p []byte) (int, error) {
return o.inner.Write(p)
}
func (o *clusterStorageDriverStagedObject) Close() error {
return o.inner.Close()
}
func (o *clusterStorageDriverStagedObject) Finalize(objid storage.ObjectID) (storage.ObjectID, error) {
calced, err := o.inner.Finalize(objid)
if err != nil {
return storage.ZeroID, err
}
o.driver.startObjectSync(calced)
return calced, nil
}