Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token ends up in the url in logs #45

Closed
slarse opened this issue Jul 5, 2018 · 0 comments
Closed

Token ends up in the url in logs #45

slarse opened this issue Jul 5, 2018 · 0 comments
Labels
bug Something isn't working
Projects
Milestone

Comments

@slarse
Copy link
Collaborator

slarse commented Jul 5, 2018

Probably not the best idea. It's the GitError subclasses. Example of PushFailedError log output:

[ERROR] Failed to push to https://gits-15.sys.kth.se/test-tools/c-week-1
return code: 1
stderr: To https://gits-15.sys.kth.se/test-tools/c-week-1
 ! [rejected]        master -> master (fetch first)
error: failed to push some refs to 'https://slarse:<SUPERSECRETTOKEN>@gits-15.sys.kth.se/test-tools/c-week-1'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

The SUPERSECRETTOKEN shouldn't be there (that's not the actual output)

@slarse slarse added the bug Something isn't working label Jul 5, 2018
@slarse slarse added this to To do in Core via automation Jul 5, 2018
@slarse slarse added this to To do in CLI via automation Jul 5, 2018
@slarse slarse added this to the Create/update repos milestone Jul 5, 2018
@slarse slarse closed this as completed in 58dffab Aug 15, 2018
Core automation moved this from To do to Done Aug 15, 2018
CLI automation moved this from To do to Done Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
CLI
  
Done
Core
  
Done
Development

No branches or pull requests

1 participant