Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenario description is missed #25

Closed
yurii-hunter opened this issue Jul 2, 2018 · 5 comments
Closed

Scenario description is missed #25

yurii-hunter opened this issue Jul 2, 2018 · 5 comments

Comments

@yurii-hunter
Copy link

Initially, we had a description for a scenario in report portal for the SpecFlow client which contained scenario steps, for now, it is missed. The change was made in the scope of this PR Initial Parallel Execution support by @aliaksandrbasau, and variable CurrentScenarioDescription is marked as Obsolete. I would like to clarify is it an issue or just the decision to get rid of this functionality?

@abasau
Copy link
Collaborator

abasau commented Jul 2, 2018

@yurii-hunter I removed it because it seemed like a solution for very specific case. I don't think that it should be a default behavior since it duplicates text of all steps in test item description. The same text can be found under test item as logs.
I understand that it can be useful in some cases but it should not be a default behavior.

It should rather be implemented in your solution using extension points (events) - collect step text in BeforeStepStarted event and update description in BeforeScenarioFinished.

I can add scenario and feature context properties to EventArgs classes so it will be easier for you to get access to them from static event handlers.

@nvborisenko What do you think about it?

@yurii-hunter
Copy link
Author

@aliaksandrbasau sounds reasonable. So, if it is by design - I'm ok. I will implement it on my own in a work project. Just wanted to make sure

@abasau
Copy link
Collaborator

abasau commented Jul 3, 2018

@yurii-hunter Please let me know if you need scenario and feature context properties in EventArgs classes.
Closing the issue for now.

@abasau abasau closed this as completed Jul 3, 2018
@nvborisenko
Copy link
Member

Let me reopen this issue. Definitely we don't want to see steps as scenario description. The future release of specflow will contain some description of scenarios (SpecFlowOSS/SpecFlow#1078). I am not sure what exactly it will contain, but let us to follow official way.

@nvborisenko nvborisenko reopened this Jul 30, 2018
@nvborisenko
Copy link
Member

Done in v1.2.4. Actual description is empty :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants