Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong view in case of suite that contains another suites #273

Closed
ulmanA opened this issue Nov 15, 2017 · 17 comments
Closed

Wrong view in case of suite that contains another suites #273

ulmanA opened this issue Nov 15, 2017 · 17 comments
Assignees
Labels
bug Bug in ReportPortal component:agent
Milestone

Comments

@ulmanA
Copy link

ulmanA commented Nov 15, 2017

Hi,
We are using TestNG and we have suite.xml file that contains suite-file tags
So I expect to see in report portal something like:

   "My_Launch":[  
      "MultiSuite":[  
         "Suite1":[  
            "test1",
            "test2"
         ],
         "Suite2":[  
            "test3",
            "test4",
            "test5",
            "test6",
            "test7",
            "test8"
         ]
      ]
   ]
}

And My_Launch will have total of 8 tests

But what actual happens:

{  
   "My_Launch":[  
      "MultiSuite":[  
      ],
      "Suite1":[  
         "test1",
         "test2"
      ],
      "Suite2":[  
         "test3",
         "test4",
         "test5",
         "test6",
         "test7",
         "test8"
      ]
   ]
}

And the total tests is 9 (it counting the multi-suite as 1 more test)
(see attached screenshoot
report portal launches
report portal - suites

)

so, there is 2 issues here:

  1. The visual representation (the child suite is beside the parent suite)
  2. The total tests and passed tests calculations are wrong
@evjlobanova
Copy link
Contributor

@ulmanA Use different methods for start your suites:

  • for the MultiSuite use POST /{projectName}/item - start root test item;
  • for Suite1 and Suite2 - POST /{projectName}/item/{parentItem} - start a child test item

Please, try to do this, and share your results with us

@ulmanA
Copy link
Author

ulmanA commented Nov 15, 2017

I am not call directly to the API.
I am using the TestNG Listener: com.epam.reportportal.testng.ReportPortalTestNGListener
From the artifact: com.epam.reportportal : agent-java-testng

@avarabyeu
Copy link
Member

@ulmanA could you please give us some example of your testng.xml file?

@ulmanA
Copy link
Author

ulmanA commented Nov 15, 2017

Here:
Suites.zip

@ulmanA ulmanA closed this as completed Nov 15, 2017
@ulmanA ulmanA reopened this Nov 15, 2017
@ulmanA
Copy link
Author

ulmanA commented Nov 15, 2017

Sorry closed by mistake

@pbortnik
Copy link
Collaborator

pbortnik commented Dec 5, 2017

@ulmanA Hello, do you want to see your root suite as the parent of other suites? How important is to see the root suite?
The problem is that testNG runs inner suites at first and after then the root one to summarize results. ReportPortal creates items on runtime, so it is difficult to change the tests' structure after inner suites have finished.
The possible solution is to ignore root suite if it has only inner suites. If the root suite has test cases as well, so it could be placed with inner suites on the same structure's level. Does it work for you?

@ulmanA
Copy link
Author

ulmanA commented Dec 13, 2017

  1. we have project here that run whole tree of suites (suite that have 4 suites that each have few inner suites and so on...).
    so with your solution we will lose all that tree (that represent separation by features for example )

  2. Maybe you can add ability to update finished test item with new parent?

@DzmitryHumianiuk
Copy link
Member

@avarabyeu @pbortnik
please check possibility to updated parents on Finish.
or consider it in statistics, based on PostgreSQL

@pbortnik pbortnik added bug Bug in ReportPortal component:agent labels Dec 21, 2017
@avarabyeu
Copy link
Member

Depends on testng-team/testng#1656

@DzmitryHumianiuk
Copy link
Member

@avarabyeu can we start automatically master object (startRQ), if child object of it started?

@avarabyeu
Copy link
Member

@DzmitryHumianiuk doesn't understand. Could you please re-phrase?

@evjlobanova
Copy link
Contributor

@DzmitryHumianiuk could you please add more details?

@DzmitryHumianiuk
Copy link
Member

@evjlobanova @avarabyeu
as i see, related issue in testNG closed without any code change.
They proposed the solution, without code change.

My question was, can we start parent suite for child suite automatically? (in case if context can give us such details)

@ulmanA can you try testNG 6.13+
and this
testng-team/testng#1656 (comment)

@ulmanA
Copy link
Author

ulmanA commented Jul 18, 2018

@DzmitryHumianiuk Still the same behavior in TestNG 6.14.3

@DzmitryHumianiuk
Copy link
Member

@ulmanA could you plz share details on your suites structure at testng-team/testng#1656 (comment)

it's testNG related issue, and we can't fix it, until testNG will provide a fix

@ulmanA
Copy link
Author

ulmanA commented Jul 31, 2018

Done.

@DzmitryHumianiuk
Copy link
Member

@ulmanA your are awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug in ReportPortal component:agent
Projects
None yet
Development

No branches or pull requests

5 participants