Skip to content
This repository has been archived by the owner on Apr 15, 2020. It is now read-only.

Changes requested in PR #10 #12

Merged
merged 46 commits into from Dec 11, 2018
Merged

Changes requested in PR #10 #12

merged 46 commits into from Dec 11, 2018

Conversation

susruth
Copy link
Contributor

@susruth susruth commented Dec 9, 2018

Description

Architecture level changes requested in the PR #10

Motivation

Cleaner and more understandable architecture.

Design

  • Replace Swapperd driver with Compose driver
  • Two foundations: Swap, Blockchain
  • All components use Run to begin a for loop and accept channels as arguments to Run (done, requests, responses)
  • Rename status.Book to status.Statuses
  • Introduce balance.Balances
  • Rename fund.Manager to wallet.Wallet
  • Move adapter/router to core/router

Related Work
PR #11
PR #13

Susruth Nadimpalli and others added 30 commits November 30, 2018 06:38
@susruth susruth self-assigned this Dec 11, 2018
@loongy
Copy link
Contributor

loongy commented Dec 11, 2018

Is the work in this PR included in #11?

@susruth
Copy link
Contributor Author

susruth commented Dec 11, 2018

Yes, but once this PR is merged. #11 will only show the differences between this and fees branch.

@loongy loongy merged commit 85ea9f4 into master Dec 11, 2018
@tok-kkk tok-kkk deleted the composer branch December 17, 2018 03:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants