Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested objects in params are being "toString"-ed #11

Closed
jesuscript opened this issue Oct 15, 2014 · 3 comments
Closed

Nested objects in params are being "toString"-ed #11

jesuscript opened this issue Oct 15, 2014 · 3 comments

Comments

@jesuscript
Copy link

Hi, I found that when the querystring contains nested objects e.g.

filter[email]=bob@bob.com

then the base string in hmacsign ends up with

filter%3D%255Bobject%2520Object%255D

rather than

filter%255Bemail%255D%3Dbob%2540bob.com

I don't think this is intentional but just wanted to confirm. Let me know and I'll raise a PR.
@EugeneKostrikov
Copy link

+1

@jesuscript jesuscript mentioned this issue Oct 16, 2014
Closed
@nylen
Copy link
Member

nylen commented Dec 11, 2014

PR welcome. Please include tests so we can prevent this from being an issue in the future!

@jeresig jeresig mentioned this issue May 24, 2015
Merged
@simov
Copy link
Member

simov commented May 26, 2015

Closed via #16

@simov simov closed this as completed May 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nylen @jesuscript @simov @EugeneKostrikov