Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerability in lodash up to v4.17.5 #12

Closed
lucaswillering opened this issue Nov 5, 2018 · 2 comments
Closed

Vulnerability in lodash up to v4.17.5 #12

lucaswillering opened this issue Nov 5, 2018 · 2 comments
Labels
Bump Patch Bump patch version once released

Comments

@lucaswillering
Copy link

There's a vulnerability in lodash versions up to 4.17.5 (https://nvd.nist.gov/vuln/detail/CVE-2018-3721) which is a dependency of promise-core. Would it be possible to update the dependency to the latest version?

@lucaswillering lucaswillering changed the title Vulnerability in lodash 4.17.5 Vulnerability in lodash up to v4.17.5 Nov 5, 2018
@andreyrd
Copy link

The package.json for request-promise-core specifies "lodash": "^4.13.1" which means a fresh install will in fact pull a version of lodash newer than 4.17.5.

So you should be able to update with npm update or similar...

This is something I've seen happen on a lot of projects, where technically a fresh install of the package will pull in a good version, but anyone who installed it previously is stuck with a vulnerable version. What's the accepted way to deal with this?

I know gulp-sass pretty consistently tells their users to just update the node-sass dependency on their own: dlmanning/gulp-sass#712

@analog-nico analog-nico added the Bump Patch Bump patch version once released label Feb 14, 2019
@analog-nico
Copy link
Member

Thanks for reporting this @lucaswillering ! I just released request-promise@4.2.3, request-promise-native@1.0.6, and request-promise-any@1.0.6 which bump lodash to @4.17.11.

@andreyrd You are right. The versioning is designed that the user can deal with vulnerabilities directly. Of course, it is a good idea for a package maintainer to eventually enforce the upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bump Patch Bump patch version once released
Projects
None yet
Development

No branches or pull requests

3 participants