Specify servername when creating secureSocket over tunneling proxy #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the https-over-http proxy work when strictSSL is turned on. In v0.8.4, we fixed a bug where an otherwise valid cert would be accepted for a host that was not listed in the CN or subjectaltnames sections of the certificate. However, this breaks proxying, because you want to accept the cert if it comes from the origin server, not tested against the proxy's hostname. This fixes isaacs/npm#2719
|
duplicate, and pull from master. Closing in favor of #318 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the https-over-http proxy work when strictSSL is turned on.
In v0.8.4, we fixed a security bug where an otherwise valid cert would be
accepted for a host that was not listed in the CN or subjectaltnames
sections of the certificate.
However, this breaks proxying, because you want to accept the cert if
it comes from the origin server, not tested against the proxy's
hostname.
This fixes isaacs/npm#2719