Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: Improve Headers UI in mock server #1134

Open
3 tasks
wrongsahil opened this issue Oct 6, 2023 · 9 comments
Open
3 tasks

enhancement: Improve Headers UI in mock server #1134

wrongsahil opened this issue Oct 6, 2023 · 9 comments

Comments

@wrongsahil
Copy link
Member

wrongsahil commented Oct 6, 2023

Right now, headers in mock server are added using JSON. This might create problems as headers can't be nested json.

Checklist

  • Add/Update Headers using +- button similar to headers rule
image
  • Add validations
  • Support old headers values
@Yogesh01000100
Copy link

I am interested in working on this issue. Can you assign this to me?

@wrongsahil
Copy link
Member Author

Hey @Yogesh01000100 .Thanks for the interest. Assigning this to you. Let me know if you need help with anything.

@Yogesh01000100
Copy link

@wrongsahil can you tell me if I need to add an autocomplete list to these header values?

@Yogesh01000100
Copy link

@wrongsahil can you tell me if I need to add an autocomplete list to these header values?

any specific validation rules that I need to add?

@wrongsahil
Copy link
Member Author

wrongsahil commented Oct 20, 2023

  • Yes, we can add autocomplete too. We already have a component which lists down all the common headers. Here are the suggestions which we are using in Headers Rule
  • isRequired validation for both key and value should be enough for now.

@Yogesh01000100
Copy link

Yes I have included that, can you check and confirm if any changes are required?

@wrongsahil
Copy link
Member Author

Awesome. Let me check the PR. Also Can you share a Session Replay for the changes also.

@Yogesh01000100
Copy link

@wrongsahil I have added the necessary changes, can this pull request be merged now? Do inform me if any changes are required.

@Yogesh01000100
Copy link

@wrongsahil can you check the status of merging this PR?

@wrongsahil wrongsahil added the issue Distinguish between PR and Issue label Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants