Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CacheClient to be usable as a mixin class #18

Closed
JWCook opened this issue Feb 20, 2021 · 1 comment
Closed

Refactor CacheClient to be usable as a mixin class #18

JWCook opened this issue Feb 20, 2021 · 1 comment
Labels
refactor
Milestone
v0.2

Comments

@JWCook
Copy link
Member

JWCook commented Feb 20, 2021

Idea from #16.

If there are additional mixins you wanted to use with aiohttp.ClientSession, it would be convenient (and cleaner) to use CacheClient as a mixin, for example:

class CustomSession(RetryMixin, CacheMixin, ClientSession):
    """Session class with retry + caching features"""
@JWCook JWCook added this to the v0.2 milestone Feb 20, 2021
@JWCook JWCook closed this as completed Feb 20, 2021
@JWCook
Copy link
Member Author

JWCook commented Feb 28, 2021

Fixed with d88c48e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor
Projects
None yet
Milestone
v0.2
Development

No branches or pull requests
1 participant
@JWCook