-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POST that sets cookies will not cache #23
Comments
First of all httpbin returns 405 status for POST /cookies In [7]: requests.post("http://httpbin.org/cookies/set?name=dfd").text
Out[7]: '<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">\n<title>405 Method Not Allowed</title>\n<h1>Method Not Allowed</h1>\n<p>The method is not allowed for the requested URL.</p>\n' Also, did you add 'POST' to In [14]: requests_cache.install_cache(allowable_methods=('GET', 'POST'))
In [15]: requests.post("http://httpbin.org/post", cookies={"foo": "bar"}).from_cache
Out[15]: False
In [16]: requests.post("http://httpbin.org/post", cookies={"foo": "bar"}).from_cache
Out[16]: True
In [17]: requests.post("http://httpbin.org/post", cookies={"foo": "bar"}).json()
Out[17]:
{'args': {},
'files': {},
'origin': 'xxxxxxxx',
'json': None,
'headers': {'Connection': 'close',
'Accept': '*/*',
'Cookie': 'foo=bar',
'X-Request-Id': '7e4e122f-9b1a-435d-86ba-7ab06d2dc16b',
'Content-Length': '0',
'User-Agent': 'python-requests/2.3.0 CPython/3.4.0 Linux/3.13.0-24-generic',
'Accept-Encoding': 'gzip, deflate',
'Host': 'httpbin.org'},
'url': 'http://httpbin.org/post',
'form': {},
'data': ''} |
Yeah I did add POST to allowable methods. Is there a httpbin for sending a POST that sets cookies? |
Looks like no. But check my example. It sets cookies while requesting http://httpbin.org/post |
You are right, I figured out what my problem was. When passing in a dictionary as any argument, the order is not defined. So when you do the same post twice, with the same options, it can be cached differently because the order changes for the dictionary. I got the idea from here: http://cachecontrol.readthedocs.org/en/latest/tips.html#query-string-params So to fix I turned the dictionary into a list of lists and passed that in sorted: s.post('url', sorted([key, value] for key, value in options.items())) |
This will not cache, for some reason
requests.post("http://httpbin.org/cookies/set?name=dfd")
The text was updated successfully, but these errors were encountered: