Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MongoDB backend: Store responses in document format instead of serialized binary #576

Closed
JWCook opened this issue Apr 13, 2022 · 0 comments · Fixed by #584
Closed

MongoDB backend: Store responses in document format instead of serialized binary #576

JWCook opened this issue Apr 13, 2022 · 0 comments · Fixed by #584
Labels
backends Features or changes related to specific backends enhancement serialization Features or changes related to response serialization
Milestone
v1.0

Comments

@JWCook
Copy link
Member

JWCook commented Apr 13, 2022

Currently, all backends (except filesystem) store responses as serialized blobs. MongoDB's internal document format, BSON, can support all the types needed to store response data as a plain document. This would have little performance benefit, but it would make it easy to view cached response data. It would also make it easier to add a TTL index for #362.

To do this, a CachedResponse object just needs to be "unstructured" with the existing CattrStage class.
@JWCook JWCook added enhancement backends Features or changes related to specific backends labels Apr 13, 2022
@JWCook JWCook added this to the v0.10 milestone Apr 13, 2022
@JWCook JWCook mentioned this issue Apr 13, 2022
Closed
@JWCook JWCook changed the title MongoDB: Store responses in document format instead of serialized binary MongoDB backend: Store responses in document format instead of serialized binary Apr 13, 2022
This was referenced Apr 13, 2022
Open
Open
@JWCook JWCook modified the milestones: v0.10, v1.0 Apr 15, 2022
@JWCook JWCook added the serialization Features or changes related to response serialization label Apr 15, 2022
@JWCook JWCook mentioned this issue Apr 15, 2022
Merged
@masavini masavini mentioned this issue Apr 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backends Features or changes related to specific backends enhancement serialization Features or changes related to response serialization
Projects
None yet
Milestone
v1.0
Development

Successfully merging a pull request may close this issue.

Improvements for MongoDB backend JWCook/requests-cache
1 participant
@JWCook