Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install_cache() with memory backend is not working properly in version 0.9.4 #617

Closed
hlYassine opened this issue Apr 28, 2022 · 2 comments
Closed
Labels
Milestone

Comments

@hlYassine
Copy link

The problem

Memory backend not working as expected.
I installed the cache using:
requests_cache.install_cache("my_cache", backend="memory", expire_after=200)

requests calls within 200sec intervall (after the first requests call) all have from_cache = False
when i switched back to persistent backend, it worked as expected.

Environment

  • requests-cache version: 0.9.4
  • Python version: 3.8.0
  • Platform: Windows 10 Entreprise, Version 1909, OS build 18363.2212
@hlYassine hlYassine added the bug label Apr 28, 2022
@JWCook JWCook added this to the v0.9 milestone Apr 28, 2022
@JWCook JWCook changed the title memory cache is not working properly in version 0.9.4 install_cache() with memory backend is not working properly in version 0.9.4 Apr 28, 2022
@JWCook
Copy link
Member

JWCook commented Apr 28, 2022

Thanks for reporting. I'll look into it.

Meanwhile, it looks like CachedSession(backend='memory') still works as expected.

@JWCook
Copy link
Member

JWCook commented Apr 29, 2022

Fixed in master, and I'll push out another patch release for 0.9 sometime in the next couple weeks.

@JWCook JWCook closed this as completed Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants