Skip to content

Commit

Permalink
fix broken things
Browse files Browse the repository at this point in the history
  • Loading branch information
@kennethreitz
kennethreitz committed Jul 4, 2018
1 parent 7079479 commit 6608010
Show file tree
Hide file tree
Showing 4 changed files with 436 additions and 336 deletions.
1 change: 1 addition & 0 deletions .gitignore
View file
@@ -1,6 +1,7 @@
env/
build/
dist/
.eggs/
.workon
.epio-app
*.pyc
Expand Down
1 change: 1 addition & 0 deletions Pipfile
View file
Expand Up @@ -15,3 +15,4 @@ flasgger = "*"
pyyaml = {git = "https://github.com/yaml/pyyaml.git"}

[dev-packages]
rope = "*"
11 changes: 9 additions & 2 deletions Pipfile.lock
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 comments on commit 6608010

@kennethreitz
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can post, just use a query parameter.

@eturk1
Copy link

@eturk1 eturk1 commented on 6608010 Jul 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why would we want to use query parms (GET) as POST form data?
seems like allowing that would just invite confusion

@javabrett
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added PR #482 which should be a nice compromise - query string params are still allowed, but for POST, PATCH or PUT with a form-data body containing url and/or status_code, these override any query-string data, or simply work if there is no query-string.

Please sign in to comment.