Timeouts are normal errors now.

-- BREAK ALL TEH TESTS!
psf · Jun 22, 2011 · 162b751 · 162b751
1 parent 20aed54
commit 162b751
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/requests/models.py b/requests/models.py
@@ -296,15 +296,15 @@ def send(self, anyway=False):
                 if self.cookiejar is not None:
                     self.cookiejar.extract_cookies(resp, req)
 
-            except urllib2.HTTPError, why:
+            except (urllib2.HTTPError, urllib2.URLError), why:
+                if hasattr(why, 'reason'):
+                    if isinstance(why.reason, socket.timeout):
+                        why = Timeout(why)
+
                 self._build_response(why)
                 if not self.redirect:
                     self.response.error = why
 
-            # TODO: Support urllib connection refused errors
-
-            except urllib2.URLError, error:
-                raise Timeout if isinstance(error.reason, socket.timeout) else error
             else:
                 self._build_response(resp)
                 self.response.ok = True

diff --git a/test_requests.py b/test_requests.py
@@ -246,8 +246,13 @@ def test_httpauth_recursion(self):
 
 
     def test_settings(self):
+
+        def test():
+            r = requests.get(httpbin(''))
+            r.raise_for_status()
+
         with requests.settings(timeout=0.0000001):
-            self.assertRaises(requests.Timeout, requests.get, httpbin(''))
+            self.assertRaises(requests.Timeout, test)
 
         with requests.settings(timeout=100):
             requests.get(httpbin(''))