almond + i18n

[fheidrich]

I'm adding NLS support to Orion (textview/editor), see https://bugs.eclipse.org/bugs/show_bug.cgi?id=369869

I have found a small problem, the i18n plugin calls a req.mixin method that is not part of almond
I was able to workaround this easily by copying the mixing from require.js to almond.js.

On a side note, since almond does not support any dynamic loading, all nls files need to be included either in the html file or during compile time.

[jrburke]

Are you using the i18n plugin from the requirejs project:

https://github.com/jrburke/requirejs/blob/master/i18n.js

If so, maybe upgrade to the latest version -- it does not use req.mixin. That should fix it. It should also inline all the bundles it loads. You may need to set the locale: in the config to do so. Right now I only think it can handle one locale though. If you have trouble with the i18n plugin, feel free to file issues under the requirejs repo.

I'm going to close this ticket for now, but if the latest version of the i18n plugin does not fix the req.mixin problem give a holler. But it was a non-standard method that I removed to try to more compliant with other AMD loaders.

[fheidrich]

my apologies, I should have checked the latest version before opening the bug. The version I am using (Orion is using for that matter) is old, version: '0.24.0'.
Thank you for note.