Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item local fields and item temporary circulation category should be indexed in the document #2211

Closed
pronguen opened this issue Jul 20, 2021 · 1 comment · Fixed by #2830
Closed
Assignees
Labels
effort: 3pt 3 point of effort estimated for the implementation enhancement Improvement of an existing feature f: search p-High High priority (to be solved in the 2-3 next months)
Milestone

Comments

@pronguen
Copy link
Contributor

pronguen commented Jul 20, 2021

How it works

They are currently not indexed in the document.

Improvement suggestion

They are indexed in the document (but check the potential performance issues of this!).

Use case

Create links to the document public view, with specific search results, for instance the new acquisitions, but filtered with the temporary circulation categories that are available. Currently, those links include also all documents that are in acquisition or in treatment.

Test the use case

  • a library has 10 codes (acq1, acq2, acq3) as subdivision for its new acquisitions. They are saved as local fields of the item.
  • this library want a specific link/URL from its website to RERO ILS public interface for the new acquisitions
    • for a subdivision, excluding some item temporary circ category (imagine all item that have the temporary category "in acquisition")

Example: link to all *documents" where one item (⚠️ nested)

  1. has an item with local code "acq1"
  2. AND is neither [with temporary circulation category] "in acquisition" nor "missing"
  3. AND was acquired in the last 3 months

How to test

image

https://localhost:5000/api/documents/?q=holdings.items.local_fields.fields.field_1:acq1%20AND%20!holdings.items.temporary_item_type.pid:14
&new_acquisition=2022-05-01
@pronguen pronguen added enhancement Improvement of an existing feature f: search p-Medium Medium priority (to be solved within 1-2 years) labels Jul 20, 2021
@iGormilhit iGormilhit added p-Medium Medium priority (to be solved within 1-2 years) triage and removed p-Medium Medium priority (to be solved within 1-2 years) triage labels Jul 20, 2021
@zannkukai
Copy link
Contributor

If I remember well, we removed the local_fields indexation for performance issue.

@pronguen pronguen added p-High High priority (to be solved in the 2-3 next months) and removed p-Medium Medium priority (to be solved within 1-2 years) labels Sep 27, 2021
@iGormilhit iGormilhit added this to the v1.7.0 milestone Oct 12, 2021
@zannkukai zannkukai self-assigned this Nov 4, 2021
@pronguen pronguen modified the milestones: v1.7.0, v1.8.0 Nov 17, 2021
@zannkukai zannkukai removed their assignment Dec 6, 2021
@pronguen pronguen added the effort: 3pt 3 point of effort estimated for the implementation label Feb 2, 2022
@pronguen pronguen modified the milestones: v1.8.0, v1.9.0 Feb 2, 2022
@pronguen pronguen modified the milestones: v1.9.0, v1.10.0 Mar 2, 2022
@pronguen pronguen added this to the v1.11.0 milestone Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort: 3pt 3 point of effort estimated for the implementation enhancement Improvement of an existing feature f: search p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants