Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: pickup deadline should be calculated starting from the checkin date #2679

Closed
ManaDeweerdt opened this issue Feb 4, 2022 · 0 comments · Fixed by #2820
Closed

Request: pickup deadline should be calculated starting from the checkin date #2679

ManaDeweerdt opened this issue Feb 4, 2022 · 0 comments · Fixed by #2820
Assignees
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend f: professional ui Professional interface p-High High priority (to be solved in the 2-3 next months)
Milestone

Comments

@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Feb 4, 2022

Describe the bug

For now, the pickup deadline is calculated starting from the request date.
Ex : https://ils.bib.uclouvain.be/professional/records/items/detail/3259079
https://ils.bib.uclouvain.be/professional/records/items/detail/3511120
https://ils.bib.uclouvain.be/professional/records/items/detail/3499505

It appears that when a request is validated with 'validate_first_pending' the request transaction_date isn't updated. It's important to do that because the loan request_expiration_date is calculated on this date.

To Reproduce

  1. Place a request on a borrowed item. (or find a borrowed item with a request on it).
  2. Wait one day and checkin the item.
  3. See the pickup deadline.

Expected behavior

The pickup deadline should be calculated from the checkin date.

Context

  • server: ucl instance
  • version: v1.8.0 or the commit hash (see frontpage).
  • browser: [if relevant, e.g. chrome, safari, version 78].

Screenshots

The 'validate request' date should be the same as the checkin date. In this example, it displays the same date as the request date.
image

Other example
image

Additional context

@ManaDeweerdt ManaDeweerdt added f: circulation Concerns the circulation interface or backend f: professional ui Professional interface triage bug Breaks something but is not blocking p-Medium Medium priority (to be solved within 1-2 years) labels Feb 4, 2022
@pronguen pronguen added this to the v1.11.0 milestone Mar 17, 2022
@ManaDeweerdt ManaDeweerdt added p-High High priority (to be solved in the 2-3 next months) and removed p-Medium Medium priority (to be solved within 1-2 years) labels Mar 17, 2022
@zannkukai zannkukai self-assigned this Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Breaks something but is not blocking f: circulation Concerns the circulation interface or backend f: professional ui Professional interface p-High High priority (to be solved in the 2-3 next months)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants