Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backprojection parameters aren't descriptive #1587

Closed
Tracked by #1586
nikolausWest opened this issue Mar 14, 2023 · 0 comments · Fixed by #1690
Closed
Tracked by #1586

Backprojection parameters aren't descriptive #1587

nikolausWest opened this issue Mar 14, 2023 · 0 comments · Fixed by #1690
Assignees
Labels
😤 annoying Something in the UI / SDK is annoying to use 📺 re_viewer affects re_viewer itself

Comments

@nikolausWest
Copy link
Member

nikolausWest commented Mar 14, 2023

Depth backprojection is very useful but it's currently hard to understand what it does because of naming and on-hover-descriptions in the selection view.

"Backproject scale" is derived from the meter parameter in the logging function log_depth_image. This blueprint (UI settable) parameter should be refactored to map 1:1 with the parameter in the log_depth_image. It should have a name that indicates as much and the on-hover description should explain how it works.
Screenshot 2023-03-14 at 16 09 30

A scale indicates that this parameter multiplies another value. The on-hover description should indicate what value this scale multiplies.
Screenshot 2023-03-14 at 16 09 39

@nikolausWest nikolausWest added 📺 re_viewer affects re_viewer itself 😤 annoying Something in the UI / SDK is annoying to use labels Mar 14, 2023
@emilk emilk self-assigned this Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
😤 annoying Something in the UI / SDK is annoying to use 📺 re_viewer affects re_viewer itself
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants